Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/multiple replace #8984

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+133 −0
Open

Feature/multiple replace #8984

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ac7e97
Add FixViaMultipleReplace feature to common errors.
ivandrofly Nov 8, 2024
a251d01
Update capitalization in FixViaMultipleReplace string.
ivandrofly Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
115 changes: 115 additions & 0 deletions src/libse/Forms/FixCommonErrors/MultipleReplace.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,115 @@
using System;
using System.Collections.Generic;
using System.Text.RegularExpressions;
using Nikse.SubtitleEdit.Core.Common;
using Nikse.SubtitleEdit.Core.Interfaces;

namespace Nikse.SubtitleEdit.Core.Forms.FixCommonErrors
{
public class MultipleReplace : IFixCommonError
{
public static class Language
{
public static string FixViaMultipleReplace { get; set; } = "Fix via Multiple Replace rules";
}

private readonly ICollection<ReplaceExpression> _replaceExpressions;
private readonly Dictionary<string, Regex> _compiledRegExList = new Dictionary<string, Regex>();

public MultipleReplace() => _replaceExpressions = LoadReplaceExpressions();

private bool IsLoaded() => _replaceExpressions.Count > 0;

public void Fix(Subtitle subtitle, IFixCallbacks callbacks)
{
if (!IsLoaded())
{
return;
}

foreach (var paragraph in subtitle.Paragraphs)
{
var text = Replace(paragraph.Text);
if (paragraph.Text != text)
{
var beforeChanges = paragraph.Text;
paragraph.Text = text;
callbacks.AddFixToListView(paragraph, Language.FixViaMultipleReplace, beforeChanges, text);
}
}
}

private string Replace(string newText)
{
foreach (ReplaceExpression item in _replaceExpressions)
{
if (item.SearchType == ReplaceExpression.SearchCaseSensitive)
{
if (newText.Contains(item.FindWhat))
{
newText = newText.Replace(item.FindWhat, item.ReplaceWith);
}
}
else if (item.SearchType == ReplaceExpression.SearchRegEx)
{
Regex r = _compiledRegExList[item.FindWhat];
if (r.IsMatch(newText))
{
newText = RegexUtils.ReplaceNewLineSafe(r, newText, item.ReplaceWith);
}
}
else
{
int index = newText.IndexOf(item.FindWhat, StringComparison.OrdinalIgnoreCase);
if (index >= 0)
{
do
{
newText = newText.Remove(index, item.FindWhat.Length).Insert(index, item.ReplaceWith);
index = newText.IndexOf(item.FindWhat, index + item.ReplaceWith.Length, StringComparison.OrdinalIgnoreCase);
} while (index >= 0);
}
}
}

return newText;
}

private ICollection<ReplaceExpression> LoadReplaceExpressions()
{
var replaceExpressions = new HashSet<ReplaceExpression>();
foreach (var group in Configuration.Settings.MultipleSearchAndReplaceGroups)
{
if (!group.Enabled)
{
continue;
}

foreach (var rule in group.Rules)
{
if (!rule.Enabled)
{
continue;
}

string findWhat = rule.FindWhat;
if (!string.IsNullOrEmpty(findWhat)) // allow space or spaces
{
string replaceWith = RegexUtils.FixNewLine(rule.ReplaceWith);
findWhat = RegexUtils.FixNewLine(findWhat);
string searchType = rule.SearchType;
var ruleInfo = string.IsNullOrEmpty(rule.Description) ? $"Group name: {group.Name} - Rule number: {group.Rules.IndexOf(rule) + 1}" : $"Group name: {group.Name} - Rule number: {group.Rules.IndexOf(rule) + 1}. {rule.Description}";
var mpi = new ReplaceExpression(findWhat, replaceWith, searchType, ruleInfo);
replaceExpressions.Add(mpi);
if (mpi.SearchType == ReplaceExpression.SearchRegEx && !_compiledRegExList.ContainsKey(findWhat))
{
_compiledRegExList.Add(findWhat, new Regex(findWhat, RegexOptions.Compiled | RegexOptions.Multiline));
}
}
}
}

return replaceExpressions;
}
}
}
7 changes: 7 additions & 0 deletions src/libse/Settings/FixCommonErrorsSettings.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ public class FixCommonErrorsSettings
public bool FixContinuationStyleTicked { get; set; }
public bool FixUnnecessaryLeadingDotsTicked { get; set; }
public bool NormalizeStringsTicked { get; set; }
public bool FixViaMultipleReplace { get; set; }
public string DefaultFixes { get; set; }


Expand Down Expand Up @@ -253,6 +254,10 @@ public void SaveUserDefaultFixes()
{
sb.Append(nameof(NormalizeStringsTicked) + ";");
}
if (FixViaMultipleReplace)
{
sb.Append(nameof(FixViaMultipleReplace) + ";");
}

DefaultFixes = sb.ToString().TrimEnd(';');
}
Expand Down Expand Up @@ -299,6 +304,7 @@ public void LoadUserDefaultFixes(string fixes)
FixContinuationStyleTicked = list.Contains(nameof(FixContinuationStyleTicked));
FixUnnecessaryLeadingDotsTicked = list.Contains(nameof(FixUnnecessaryLeadingDotsTicked));
NormalizeStringsTicked = list.Contains(nameof(NormalizeStringsTicked));
FixViaMultipleReplace = list.Contains(nameof(FixViaMultipleReplace));
}

public void SetDefaultFixes()
Expand Down Expand Up @@ -334,6 +340,7 @@ public void SetDefaultFixes()
FixContinuationStyleTicked = false;
FixUnnecessaryLeadingDotsTicked = true;
NormalizeStringsTicked = false;
FixViaMultipleReplace = false;
SaveUserDefaultFixes();
}
}
Expand Down
7 changes: 7 additions & 0 deletions src/libse/Settings/Settings.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5258,6 +5258,12 @@ public static Settings CustomDeserialize(string fileName)
settings.CommonErrors.NormalizeStringsTicked = Convert.ToBoolean(subNode.InnerText, CultureInfo.InvariantCulture);
}

subNode = node.SelectSingleNode("FixViaMultipleReplace");
if (subNode != null)
{
settings.CommonErrors.FixViaMultipleReplace = Convert.ToBoolean(subNode.InnerText, CultureInfo.InvariantCulture);
}

subNode = node.SelectSingleNode("DefaultFixes");
if (subNode != null)
{
Expand Down Expand Up @@ -9610,6 +9616,7 @@ public static string CustomSerialize(Settings settings)
xmlWriter.WriteElementString("FixContinuationStyleTicked", settings.CommonErrors.FixContinuationStyleTicked.ToString(CultureInfo.InvariantCulture));
xmlWriter.WriteElementString("FixUnnecessaryLeadingDotsTicked", settings.CommonErrors.FixUnnecessaryLeadingDotsTicked.ToString(CultureInfo.InvariantCulture));
xmlWriter.WriteElementString("NormalizeStringsTicked", settings.CommonErrors.NormalizeStringsTicked.ToString(CultureInfo.InvariantCulture));
xmlWriter.WriteElementString("FixViaMultipleReplace", settings.CommonErrors.FixViaMultipleReplace.ToString(CultureInfo.InvariantCulture));
xmlWriter.WriteElementString("DefaultFixes", settings.CommonErrors.DefaultFixes);
xmlWriter.WriteEndElement();

Expand Down
4 changes: 4 additions & 0 deletions src/ui/Forms/FixCommonErrors.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ public sealed partial class FixCommonErrors : Form, IFixCallbacks
private const int IndexRemoveDashFirstLine = 32;
private const int IndexNormalizeStrings = 33;
private const int IndexFixEllipsesStart = 34;
private const int IndexFixViaMultipleReplace = 35;
private int _indexAloneLowercaseIToUppercaseIEnglish = -1;
private int _turkishAnsiIndex = -1;
private int _danishLetterIIndex = -1;
Expand Down Expand Up @@ -427,6 +428,8 @@ private void AddFixActions(string threeLetterIsoLanguageName)
new FixItem(_language.BreakDialogsOnOneLine, _language.FixDialogsOneLineExample, () => new FixDialogsOnOneLine().Fix(Subtitle, this), ce.FixDialogsOnOneLineTicked),
new FixItem(_language.RemoveDialogFirstInNonDialogs, _language.RemoveDialogFirstInNonDialogsExample, () => new RemoveDialogFirstLineInNonDialogs().Fix(Subtitle, this), ce.RemoveDialogFirstLineInNonDialogs),
new FixItem(_language.NormalizeStrings, string.Empty, () => new NormalizeStrings().Fix(Subtitle, this), ce.NormalizeStringsTicked),
new FixItem(Nikse.SubtitleEdit.Core.Forms.FixCommonErrors.MultipleReplace.Language.FixViaMultipleReplace,
string.Empty, () => new Nikse.SubtitleEdit.Core.Forms.FixCommonErrors.MultipleReplace().Fix(Subtitle, this), ce.FixViaMultipleReplace),
};

if (Configuration.Settings.General.ContinuationStyle == ContinuationStyle.None)
Expand Down Expand Up @@ -1096,6 +1099,7 @@ private void SaveConfiguration()
ce.FixDialogsOnOneLineTicked = listView1.Items[IndexDialogsOnOneLine].Checked;
ce.RemoveDialogFirstLineInNonDialogs = listView1.Items[IndexRemoveDashFirstLine].Checked;
ce.NormalizeStringsTicked = listView1.Items[IndexNormalizeStrings].Checked;
ce.FixViaMultipleReplace = listView1.Items[IndexFixViaMultipleReplace].Checked;
if (_danishLetterIIndex >= 0)
{
ce.DanishLetterITicked = listView1.Items[_danishLetterIIndex].Checked;
Expand Down