Fix S3 bucket force_destroy logic, add existing bucket management, and bucket integration tests - #5
Merged
Merged
Conversation
…d bucket integration tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix S3 bucket force_destroy logic and add existing bucket management
Fix common_force_destroy: changed from OR to AND so only active sources
determine the bucket's force_destroy setting. Previously, disabled sources'
default (true) overrode an active source's explicit false, causing unintended
bucket deletion on terraform destroy.
Add existing bucket support: when create_bucket=false, the module now reads
the existing bucket's policy, appends required service principals (preserving
customer statements), and configures S3→SNS notifications.
Add bucket integration tests covering retention on destroy, force-destroy
cleanup, shared bucket with mixed force_destroy settings, existing bucket
policy append, and multi-source existing bucket scenarios.