-
Couldn't load subscription status.
- Fork 37
SB-27408 | Assessment archival to update existing requests #499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-4.5.0
Are you sure you want to change the base?
SB-27408 | Assessment archival to update existing requests #499
Conversation
…factor-changes Assessment archival refactor changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kumarks1122 @utk14 - Plase make the code changes -
- In the subclass, define the archival format; each job has its own archival format.
- Do not include archiving logic in the base class. Allow the subclass to implement, and the base class should take the archival status and update the database.
- Remove any logs that are no longer required.
- Eliminate hardcoding the year and week number. For example, (how do we do it here if I only want to archive for a year and a month?)
data-products/src/main/scala/org/sunbird/analytics/archival/BaseArchivalJob.scala
Outdated
Show resolved
Hide resolved
data-products/src/main/scala/org/sunbird/analytics/archival/BaseArchivalJob.scala
Outdated
Show resolved
Hide resolved
data-products/src/main/scala/org/sunbird/analytics/archival/BaseArchivalJob.scala
Outdated
Show resolved
Hide resolved
data-products/src/main/scala/org/sunbird/analytics/archival/BaseArchivalJob.scala
Outdated
Show resolved
Hide resolved
data-products/src/main/scala/org/sunbird/analytics/archival/BaseArchivalJob.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary.
- week and year is hardcoded in the base class and metastore class.
- Please remove the unwanted logs and printing dataframes.
- Please add a filter logic to filter the collection type (course/survey etc.)
data-products/src/main/scala/org/sunbird/analytics/archival/AssessmentArchivalJob.scala
Outdated
Show resolved
Hide resolved
data-products/src/main/scala/org/sunbird/analytics/archival/AssessmentArchivalJob.scala
Outdated
Show resolved
Hide resolved
data-products/src/main/scala/org/sunbird/analytics/archival/AssessmentArchivalJob.scala
Outdated
Show resolved
Hide resolved
data-products/src/main/scala/org/sunbird/analytics/archival/AssessmentArchivalJob.scala
Outdated
Show resolved
Hide resolved
data-products/src/main/scala/org/sunbird/analytics/archival/BaseArchivalJob.scala
Outdated
Show resolved
Hide resolved
data-products/src/main/scala/org/sunbird/analytics/archival/util/ArchivalMetaDataStoreJob.scala
Outdated
Show resolved
Hide resolved
data-products/src/main/scala/org/sunbird/analytics/archival/util/ArchivalMetaDataStoreJob.scala
Outdated
Show resolved
Hide resolved
data-products/src/main/scala/org/sunbird/analytics/archival/util/ArchivalMetaDataStoreJob.scala
Outdated
Show resolved
Hide resolved
data-products/src/main/scala/org/sunbird/analytics/archival/util/ArchivalMetaDataStoreJob.scala
Outdated
Show resolved
Hide resolved
data-products/src/main/scala/org/sunbird/analytics/archival/BaseArchivalJob.scala
Outdated
Show resolved
Hide resolved
|
SonarCloud Quality Gate failed. |








Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Type of change
Please choose appropriate options.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes in the below checkboxes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: