Modifying sim_real to support XCFs and 16-pulse sequence#624
Open
Modifying sim_real to support XCFs and 16-pulse sequence#624
Conversation
Contributor
|
@egthomas , I will try to help with this though I am going to be somewhat busy with other things in the next two to three weeks. |
Member
Author
|
@pasha-ponomarenko no problem, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the title suggests, this pull request builds on #521 by adding XCF support to
sim_real, which we believe was intended to take a FITACF-format file as input and generate simulated ACFs for each beam and range gate where the quality flag was set to 1 (ie for subsequent testing of different fitting algorithms). I've also added support for the extended 16-pulse sequence that was previously added tomake_sim.One outstanding issue (that hopefully @pasha-ponomarenko can help address) - I do not think the
noise_levparameter is being handled correctly. In AJ's original implementation, he used a plain-text file where some input value ofnoise_levwas used to scale the lag0 power to assignamp0at each range gate, egIn AJ's original code he set the
noise.searchfield in the output RAWACF file's parameter block to this input value, so I naively assumed thatnoise.searchfrom the input FITACF file could be used asnoise_levfor the above amplitude scaling. However this does not appear to be the case (at least not for the MSI-style radars like Christmas Valley and Iceland I've tested), causing the subsequent fits to the ACFs and XCFs to fail and the calculated SNR's to be wrong.