Contributing Token and MintShop changes being used in Choir.#11
Open
LiamEClancy wants to merge 4 commits intomasterfrom
Open
Contributing Token and MintShop changes being used in Choir.#11LiamEClancy wants to merge 4 commits intomasterfrom
LiamEClancy wants to merge 4 commits intomasterfrom
Conversation
TimTinkers
requested changes
Sep 10, 2021
|
|
||
| /// A mapping of data for each item group. | ||
| function itemGroups (uint256) external view returns (ItemGroup memory); | ||
| /* function itemGroups (uint256) external view returns (bool initialized, string memory _name, uint8 supplyType, uint256 supplyData, uint8 itemType, uint256 itemData, uint8 burnType, uint256 burnData, uint256 _circulatingSupply, uint256 _mintCount, uint256 _burnCount); */ |
Member
There was a problem hiding this comment.
nit: delete this unneeded comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Choir I'm giving away tokens with each item minted. These tokens are non-transferable until a later time when I explicitly activate token transfers. I've modified the
Tokencontract to support optional initialization as non-transferable and added aPermitControl-based unlock function. I also updated theMintShop1155to support giving out tokens as accompaniments to sold items.