impl. night brightness control #22
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replaced fixed nighttime schedule with dynamic sunrise/sunset times from exisiting api calls so it adapts to season and location
|
This would be a great change! +1 to implement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all thank you very much for this great project and implementation.
I was looking at the night mode as I just had build the project and printed the case and everything, as said the project works seemlessly and easy.
The only request I would have I put in this Pull Request :)
The night mode should support either a fixed value or a slider that the user can choose how much the display should be dimmed.
I needed to scale down the Settings menu a bit to fit in an additional slider into the menu but wanted to at least create this request to may share that idea / implementation with you.
I manually created the translations and of course don´t be sure if they are really 100 percent crrect but at least I also wanted to add them as a base.
Additional:
I added automatic nightmode detection based on api response as the sunset / sunrise was very easy to to add to the open-meteo api call.
In the Serial log you will see:
11:03:56.291 -> Sunrise: 06:17, Sunset: 20:11The Nightmode will use the response from the API Call to detect when Nightmode should be activated.
Once again - thanks alot for that nice project.