Add hidden library categories with a client-side lock - #1145
Add hidden library categories with a client-side lock#1145manilkadev3-max wants to merge 1 commit into
Conversation
ca0ea53 to
3e591dc
Compare
|
Client side password protection makes no sense. Anyone who has access to the server can just modify the client data |
3e591dc to
72e0d8d
Compare
|
Thank you for pointing this out. You are right that verification and filtering performed entirely by the client cannot provide an access-control boundary. I have updated the title, description, and user-facing wording to describe this as client-side concealment using an access code; it does not restrict server API access. Would this explicitly limited scope be acceptable for the WebUI? If actual access control is required, would a fully server-backed implementation be within the project scope, with verification, unlock expiration, and category filtering enforced by Suwayomi-Server? Otherwise, I am happy to close this PR and keep the feature as a local customization. |
|
I think making it possible to hide categories is enough. The whole "client side authentication" stuff is overkill |
Summary
Scope
This feature provides client-side UI concealment for shared browser sessions. It is not an access-control boundary.
An authenticated user with API access or control over the browser can bypass the lock and access the underlying category data.
Testing
pnpm format:checkpnpm tscpnpm lintpnpm build