Skip to content

Add hidden library categories with a client-side lock - #1145

Open
manilkadev3-max wants to merge 1 commit into
Suwayomi:masterfrom
manilkadev3-max:feature/hidden-library-categories
Open

Add hidden library categories with a client-side lock#1145
manilkadev3-max wants to merge 1 commit into
Suwayomi:masterfrom
manilkadev3-max:feature/hidden-library-categories

Conversation

@manilkadev3-max

@manilkadev3-max manilkadev3-max commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • allow selected categories to be hidden from the library interface
  • reveal hidden categories by entering an access code through Library search
  • provide manual locking and an optional configurable timed relock
  • store the preference through existing WebUI metadata

Scope

This feature provides client-side UI concealment for shared browser sessions. It is not an access-control boundary.

An authenticated user with API access or control over the browser can bypass the lock and access the underlying category data.

Testing

  • pnpm format:check
  • pnpm tsc
  • pnpm lint
  • pnpm build
  • verified category configuration, correct and incorrect access codes, search-field unlocking, manual and automatic relocking, persistence, and desktop and mobile layouts

@manilkadev3-max
manilkadev3-max force-pushed the feature/hidden-library-categories branch from ca0ea53 to 3e591dc Compare August 8, 2026 20:33
@schroda

schroda commented Aug 9, 2026

Copy link
Copy Markdown
Collaborator

Client side password protection makes no sense. Anyone who has access to the server can just modify the client data

@manilkadev3-max
manilkadev3-max force-pushed the feature/hidden-library-categories branch from 3e591dc to 72e0d8d Compare August 14, 2026 14:31
@manilkadev3-max manilkadev3-max changed the title Add password-protected hidden library categories Add hidden library categories with a client-side lock Aug 14, 2026
@manilkadev3-max

Copy link
Copy Markdown
Contributor Author

Thank you for pointing this out. You are right that verification and filtering performed entirely by the client cannot provide an access-control boundary. I have updated the title, description, and user-facing wording to describe this as client-side concealment using an access code; it does not restrict server API access.

Would this explicitly limited scope be acceptable for the WebUI? If actual access control is required, would a fully server-backed implementation be within the project scope, with verification, unlock expiration, and category filtering enforced by Suwayomi-Server? Otherwise, I am happy to close this PR and keep the feature as a local customization.

@schroda

schroda commented Aug 15, 2026

Copy link
Copy Markdown
Collaborator

I think making it possible to hide categories is enough. The whole "client side authentication" stuff is overkill

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants