Improve log when secret is not found in keyVault #173
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to error handling and logging when interacting with Azure Key Vault. The changes primarily focus on providing more detailed error messages by including the path of the secret that caused the error.
Improvements to error handling:
src/Confix.Tool/src/Confix.Library/ThrowHelper.cs: Modified theSecretNotFoundmethod to accept an optionalpathparameter and include it in the error message if provided.Updates to method signatures:
src/Confix.Tool/src/Confix.Library/Utilities/Azure/KeyVaultExtension.cs: Updated theHandleKeyVaultExceptionmethod to accept an optionalpathparameter and pass it to theSecretNotFoundmethod.Enhancements to Azure Key Vault provider:
src/Confix.Tool/src/Confix.Library/Variables/Providers/AzureKeyVault/AzureKeyVaultProvider.cs: Updated theResolveAsyncandSetAsyncmethods to pass thepathparameter to theHandleKeyVaultExceptionmethod. [1] [2]- mention secret path in error message when available