[phpspec-2-phpunit] migration of tests (StateMachine) #955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
loic425
commented
Oct 18, 2024
loic425
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | |
| License | MIT |
26 tasks
diimpp
approved these changes
Jun 25, 2025
diimpp
requested changes
Jun 25, 2025
src/Component/tests/StateMachine/State/ApplyStateMachineTransitionProcessorSpec.php
Show resolved
Hide resolved
loic425
force-pushed
the
phpunit-2-phpspec/state-machine
branch
from
dfd3ad6 to
1f23ce0
Compare
mamazu
reviewed
Jun 26, 2025
Comment on lines
+37
to
+40
| public function testItIsInitializable(): void | ||
| { | ||
| $this->assertInstanceOf(OperationStateMachine::class, $this->operationStateMachine); | ||
| } |
There was a problem hiding this comment.
This can be removed as it would crash in the setup method if that was not the case.
There was a problem hiding this comment.
@mamazu sounds good, let's do it in a follow-up PR
diimpp
approved these changes
Jun 26, 2025
GSadee
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.