Add Operation defaults trait #984
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic425
force-pushed
the
operation_defaults_trait
branch
from
7c915c4 to
92ecfbd
Compare
loic425
force-pushed
the
operation_defaults_trait
branch
from
92ecfbd to
f1545bf
Compare
diimpp
approved these changes
Mar 25, 2025
| } | ||
|
|
||
| if (null === $operation->getTwigContextFactory()) { | ||
| $operation = $operation->withTwigContextFactory('sylius.twig.context.factory.default'); |
There was a problem hiding this comment.
Unrelated to current PR, but why metadata factory is aware of the service ID? Should be handled via tagging/configuration/interfaces instead.
Co-authored-by: Dmitri Perunov <[email protected]>
loic425
force-pushed
the
operation_defaults_trait
branch
from
18b3a50 to
eaee288
Compare
GSadee
approved these changes
Apr 9, 2025
Comment on lines
+24
to
+26
| /** | ||
| * @internal | ||
| */ |
There was a problem hiding this comment.
Suggested change
| /** | |
| * @internal | |
| */ | |
| /** @internal */ |
|
Thank you Loic! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.