Skip to content

Fix fallback queries#87

Closed
bbartley wants to merge 4 commits into
SynBioDex:masterfrom
bbartley:85-fallback_on_lookup_failures
Closed

Fix fallback queries#87
bbartley wants to merge 4 commits into
SynBioDex:masterfrom
bbartley:85-fallback_on_lookup_failures

Conversation

@bbartley

@bbartley bbartley commented Jun 5, 2025

Copy link
Copy Markdown
Collaborator

Restores fallback queries on local graphs when network connection fails or ontology service is down.

Marks PubChem test as failure pending resolution of #86

@bbartley
bbartley force-pushed the 85-fallback_on_lookup_failures branch 2 times, most recently from c20b22a to 8ebf35f Compare June 5, 2025 16:56
@bbartley
bbartley force-pushed the 85-fallback_on_lookup_failures branch from 8ebf35f to ce0a15d Compare June 5, 2025 17:05
@jakebeal

jakebeal commented Jun 5, 2025

Copy link
Copy Markdown
Contributor

Looks good to me, except for the fact that the tests aren't currently succeeding.

@bbartley
bbartley requested a review from jakebeal June 5, 2025 23:57
@bbartley bbartley mentioned this pull request Jun 6, 2025
@bbartley

bbartley commented Jun 6, 2025

Copy link
Copy Markdown
Collaborator Author

Replacing this PR with #89. This PR was unwittingly based off my personal fork which has an out-of-date master branch. Hence, it was introducing some confusing regressions.

@bbartley bbartley closed this Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants