metrics and docs #25
Merged
metrics and docs #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
casperdcl
commented
Jun 28, 2024
•
casperdcl
commented
- metrics callback based on https://github.com/TomographicImaging/Hackathon-000-Stochastic-QualityMetrics
- improved local run docs
casperdcl
added
documentation
casperdcl
force-pushed
the
metrics-and-docs
branch
from
070d766 to
5aec470
Compare
KrisThielemans
requested changes
Jun 28, 2024
| python | ||
| docker run --rm -it -v /path/to/data:/mnt/share/petric:ro -v .:/workdir -w /workdir synerbi/sirf:edge-gpu /bin/bash | ||
| # ... or ideally synerbi/sirf:latest-gpu after the next SIRF release! | ||
| pip install git+https://github.com/TomographicImaging/Hackathon-000-Stochastic-QualityMetrics |
There was a problem hiding this comment.
Why not add this to our docker image? But this is fine of course
There was a problem hiding this comment.
I think it'll change a lot right now, and eventually be baked in to CIL itself, so wouldn't add it to the SIRF image for now.
petric.py
Outdated
| TensorBoard(logdir=outdir, transverse_slice=transverse_slice, coronal_slice=coronal_slice)] | ||
| (tb_cbk := TensorBoard(logdir=outdir, transverse_slice=transverse_slice, coronal_slice=coronal_slice))] | ||
|
|
||
| if ground_truth: |
There was a problem hiding this comment.
I prefer to rename ground_truth to converged_image
|
Looks like I cannot review again via the app. But it's good to go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.