fix(installer): use npm cli for Pro artifact install under npx#778
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (8)
✅ Files skipped from review due to trivial changes (5)
WalkthroughVersion 5.2.9 release that fixes Pro artifact installation when invoked via ChangesNpm path resolution fix and test coverage
Version and manifest synchronization
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
📊 Coverage ReportCoverage report not available
Generated by PR Automation (Story 6.1) |
441b090 to
fd40047
Compare
Summary
npx -p @aiox-squads/core aiox installnpm-cli.jswhennpm_execpathpoints tonpx-cli.js@aiox-squads/coreto 5.2.9 and@aiox-squads/installerto 3.3.8Root Cause
In Linux/npm flows,
npm_execpathcan point atnpx-cli.js. The installer trusted that value as npm and effectively rannode npx-cli.js install <pro-artifact.tgz> --prefix <target>, which dispatches to aninstallpackage/binary and fails withunexpected argument --prefix found.Verification
npx jest tests/installer/pro-setup-auth.test.js tests/installer/pro-setup-target-install.test.js --runInBand --forceExitnpm run validate:publishnpm run lintnpm run test:cigit diff --checkUser Check
jpvalente72@gmail.comis not blocked by seats: license has 2/3 active seats and 1 available.Summary by CodeRabbit
Bug Fixes
Chores
Tests
Documentation