Skip to content

Feature/homework 8 #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open

Feature/homework 8 #11

wants to merge 29 commits into from

Conversation

s0557917
Copy link
Contributor

@s0557917 s0557917 commented Jan 29, 2021

  • Our implementation of homework 8
  • As this branch branches off from feature/homework-7 there are some changes under the Files Changed which belong to the implementation of homework 7 and not 8

@florianthom florianthom requested a review from a team February 16, 2021 10:53
@florianthom florianthom requested a review from a team February 16, 2021 10:53
Copy link
Contributor

@medizinmensch medizinmensch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Team!

Thanks for the PR, it looks very good - same goes for your frontend visually.
As you pointed out yourself, it would have been nice to have less clutter in the files changed tab. Next time, why don't you set the target branch to feature/homework-7? You can also change it afterwards.

Also kudos for going the extra mile and integrating the whole thing into your app with login and stuff. Very nice!

⭐ For a header and it's responsiveness (direct links vs. hamburger menu)
⭐ For a content section and it's content items
⭐ For a responsive content section (3-column vs 1-column layout)
⭐ For responsive content items (1-column vs. 2-column layout)
⭐ For a footer

That makes 5/5 ⭐ for this exercise.

In total, you got 61/70 ⭐ for all the exercises. You will probably see your final grade the next few days in LSF. Congrats to finishing this course! Until then...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants