-
Notifications
You must be signed in to change notification settings - Fork 3
feat: 단축키 및 익스텐션 아이콘 클릭 명령어 수정 #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Caution Review failedThe pull request is closed. Walkthrough이 변경 사항은 브라우저 확장 프로그램의 툴바 아이콘 클릭 시 동작을 기존의 모달 토글에서 새로운 아이콘 토글 핸들러로 교체하고, iframe의 가시성 상태를 ALT+A 및 ALT+V 단축키와 연동하여 세밀하게 관리하는 로직을 추가합니다. 여러 핸들러에서 iframe 표시 및 상태 플래그 관리가 강화되었습니다. Changes
Sequence Diagram(s)sequenceDiagram
participant User as 사용자
participant Browser as 브라우저
participant BG as 백그라운드 스크립트
participant Tab as 활성 탭
User->>Browser: 툴바 아이콘 클릭
Browser->>BG: chrome.action.onClicked 이벤트
BG->>BG: handleIconToggle() 호출
BG->>Browser: 활성 탭 조회
BG->>Tab: 스크립트 주입(iframe 상태 확인 및 토글)
alt ALT+A로 숨겨진 경우
Tab-->>BG: iframe 생성하지 않고 종료
else ALT+V로 숨겨진 경우
Tab->>Tab: iframe 새로 생성 및 플래그 초기화
else iframe 이미 있음
Tab->>Tab: postMessage로 토글, 필요시 제거 및 플래그 갱신
end
Possibly related PRs
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
src/background/listeners/sidebarCommandHandler.tsOops! Something went wrong! :( ESLint: 9.27.0 Error: The 'jiti' library is required for loading TypeScript configuration files. Make sure to install it. src/background/index.tsOops! Something went wrong! :( ESLint: 9.27.0 Error: The 'jiti' library is required for loading TypeScript configuration files. Make sure to install it. src/background/listeners/iframeCommandHandler.tsOops! Something went wrong! :( ESLint: 9.27.0 Error: The 'jiti' library is required for loading TypeScript configuration files. Make sure to install it.
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (5)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
🧐 체크리스트
yarn build또는npm run build실행 후 정상적으로 동작하는지 확인했나요?yarn test)yarn lint및yarn prettify실행 후 문제가 없나요?feat:,fix:,chore:등 커밋 컨벤션을 따르고 있나요?README.md또는 관련 문서를 업데이트했나요?Summary by CodeRabbit