-
Notifications
You must be signed in to change notification settings - Fork 3
[Design] 메뉴바에 취소 버튼 모두 추가 #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Caution Review failedThe pull request is closed. Walkthrough여러 설정 패널 컴포넌트(ControlFont, ControlMode, ControlService)에 onClose 콜백 prop과 hasChanged 상태를 추가하여 변경 여부에 따라 버튼 라벨이 동적으로 바뀌고, 닫기 동작을 수행할 수 있도록 구조를 개선했습니다. PanelContent와 iframe.tsx도 prop 전달 구조가 변경되었습니다. ShortcutTab에는 새로운 단축키 안내가 추가되었습니다. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant PanelContent
participant ControlFont/ControlMode/ControlService
User->>PanelContent: 메뉴 선택
PanelContent->>ControlFont/ControlMode/ControlService: onClose 콜백과 함께 컴포넌트 렌더
User->>ControlFont/ControlMode/ControlService: 설정 변경
ControlFont/ControlMode/ControlService->>ControlFont/ControlMode/ControlService: hasChanged 상태 업데이트
User->>ControlFont/ControlMode/ControlService: 완료/닫기 버튼 클릭
ControlFont/ControlMode/ControlService->>PanelContent: onClose() 호출 (setMenuId(null))
PanelContent->>PanelContent: 패널 닫힘
Possibly related PRs
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
src/components/fontButton/ControlFont.tsxOops! Something went wrong! :( ESLint: 9.27.0 Error: The 'jiti' library is required for loading TypeScript configuration files. Make sure to install it. src/components/modeButton/ControlMode.tsxOops! Something went wrong! :( ESLint: 9.27.0 Error: The 'jiti' library is required for loading TypeScript configuration files. Make sure to install it. src/components/shortcutTab/component.tsxOops! Something went wrong! :( ESLint: 9.27.0 Error: The 'jiti' library is required for loading TypeScript configuration files. Make sure to install it.
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (6)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
🧐 체크리스트
yarn build또는npm run build실행 후 정상적으로 동작하는지 확인했나요?yarn test)yarn lint및yarn prettify실행 후 문제가 없나요?feat:,fix:,chore:등 커밋 컨벤션을 따르고 있나요?README.md또는 관련 문서를 업데이트했나요?Summary by CodeRabbit
New Features
개선 사항