Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make rotate attribute of type teidata.numeric #2638

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

rettinghaus
Copy link
Contributor

This PR changes zone@rotate into teidata.numeric in order to allow negative and non-integer values.
Closes #2637

@ebeshero
Copy link
Member

@rettinghaus Thanks for this! Council members raise a good question of why we might have limited ourselves to positive integers only in the first place, so we want to discuss this first before deciding whether to merge!

@martindholmes
Copy link
Contributor

There isn't a single example of the use of @rotate in the Guidelines, nor is it mentioned anywhere in the prose. That's no reason to reject this PR, but it would be good to see some examples. This might be an easy one to start with:

https://graves.uvic.ca/gr01_0472_004.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zone can only be rotated by full degrees
4 participants