Skip to content
This repository was archived by the owner on Sep 28, 2026. It is now read-only.

ci: drop the no-op deploy-live profile flag - #17

Merged
ryanbarlow97 merged 1 commit into
mainfrom
chore/remove-legacy-references
Sep 24, 2026
Merged

ryanbarlow97 merged 1 commit into
mainfrom
chore/remove-legacy-references

Conversation

@ryanbarlow97

@ryanbarlow97 ryanbarlow97 commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Remove -P'!deploy-live' from the Maven commands. No POM defines a deploy-live profile, so the flag does nothing.

Verification

  • The build workflow runs on this PR. The release workflow gets the same edits but only runs on tags.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated the automated build and release process. These changes do not alter app functionality or the end-user experience.

No POM defines a deploy-live profile, so -P'!deploy-live' does nothing.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: f1c9dbfd-7597-4d41-9269-8c0a40ab8bc9

📥 Commits

Reviewing files that changed from the base of the PR and between 20ebe5d and fc860bd.

📒 Files selected for processing (2)
  • .github/workflows/build.yml
  • .github/workflows/maven-release.yml

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The build and Maven release workflows no longer explicitly deactivate the deploy-live profile in version-setting, final-name evaluation, and build or verification commands. Maven now uses its normal profile selection for these commands.

Changes

Maven workflow profile selection

Layer / File(s) Summary
Use default Maven profile selection
.github/workflows/build.yml, .github/workflows/maven-release.yml
The version-setting, final-name evaluation, and build or verification commands no longer pass the option that disables deploy-live.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to fc860

The changed Maven commands have no deploy-live profile to activate in the checked-in project or workflow configuration. No actionable merge-blocking risk is established.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: removing the no-op deploy-live profile flag from CI Maven commands.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

A rabbit checks the build commands with care,
No profile switch to hide deploy-live is there.
The release steps use Maven’s usual way,
The build steps follow suit today.
I nibble, then hop off to play.

Comment @coderabbitai help to get the list of available commands.

@ryanbarlow97
ryanbarlow97 merged commit 7ea1e05 into main Sep 24, 2026
2 checks passed
@ryanbarlow97
ryanbarlow97 deleted the chore/remove-legacy-references branch September 24, 2026 21:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant