Repository navigation
feat: per-action points, milestone rewards, click-to-claim - #5
Merged
Merged
Conversation
Bar is now bar.max points (default 20) filled 1 point per action, with a claimable reward every bar.reward-every points (default 10). Each activity has every/points/daily-cap instead of daily-goal/points. Rewards are claimed by clicking the chest in /activity rather than auto-granted, so the pending-reward flag and join-time payout go away. Adds a 'quest' activity fed by /activity add from the quests plugin.
JustinasLa
force-pushed
the
feat/milestone-bar
branch
from
September 10, 2026 19:17
7f2ad04 to
f382425
Compare
Clamp stored points to bar.max on load and on every get(), seed 'claimed' from the legacy 'rewarded' flag, and refuse an activity that still uses 'daily-goal' instead of every/points/daily-cap. Without these an unconverted players.yml could pay out ten rewards on one click and an unconverted config.yml could fill the bar with a single action. worth() moves onto ActivityDef, where its inputs live.
…ssage A pre-milestone players.yml is now loaded with every milestone its clamped points reach already marked claimed, so an upgrade makes nothing instantly claimable. PlaceholderAPI reads clamp to bar.max as well, since peek() skips the clamp get() does. A claim whose commands could not run tells the player, not just the console. Sound comments describe the new per-point meaning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bar.maxpoints (20), 1 point per action; reward claimable everybar.reward-every(10)every/points/daily-capreplacedaily-goal/pointsquestactivity, fed by/activity add <player> quest 1from the quests plugin/activity; same commands each milestonerewarded/pending-rewardin players.yml →claimedcount; join now only nudges%activity_max%,%activity_claimable%;percentnow a real percentMath check
5 vote sites + 5 daily quests = 10/day → 2 days maxes 20. Skip one source → 4 days.
Test plan
mvn clean packagegreen, 43 tests pass