Skip to content

fix: stop the branding status listing hit counts - #35

Merged
XxFran10xX merged 1 commit into
mainfrom
fix/branding-status-no-spoilers
Oct 8, 2026
Merged

XxFran10xX merged 1 commit into
mainfrom
fix/branding-status-no-spoilers

Conversation

@XxFran10xX

Copy link
Copy Markdown
Contributor

Why

Players are meant to work out each recipe's hit split themselves, and only the finished item's percent should tell them how they did. #34 made the branding tool's right-click status list how many times each configured hit had been used. That turns it into a tracker for exactly what players are supposed to work out.

Changes

  • CraftingStation.getStatusLines() now shows only the recipe name, the material groups (Metal: 1/2, the same as the add-material title) and the finish/cancel lines. The per-hit counts are gone.
  • The Show per-hit counts when right-clicking a station with the branding tool #34 HitLoader change stays: map.clear() on reload keeps removed hits from lingering.
  • The station's existing in-world feedback (hit-type titles, hit-overshoot-warn-* config) is unchanged.

Tests

  • StationCoverageTest.statusLinesShowMaterialsButNoHitCounts checks that recorded hits never show up in the status.
  • mvn verify passes locally, apart from EdgeCoverageTest and StationDatabaseCoverageTest. Their file-permission/temp-dir tests fail on Windows on main too, so CI covers them. CraftingStation and CraftingManager stay at 100% coverage.

🤖 Generated with Claude Code

The branding tool's right-click status listed how often each configured
hit had been used, which helps players track the hit split they are meant
to work out themselves. It now shows only the recipe, the material groups
still to fill and how to finish or cancel.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@XxFran10xX

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 268adbf8-921d-4b4b-9be6-1f8106fd0fed
📥 Commits

Reviewing files that changed from the base of the PR and between 4a5c7ad and 576af68.

📒 Files selected for processing (3)
  • src/main/java/net/tfminecraft/advancedcrafting/objects/crafting/CraftingStation.java
  • src/test/java/net/tfminecraft/advancedcrafting/CraftingManagerCoverageTest.java
  • src/test/java/net/tfminecraft/advancedcrafting/StationCoverageTest.java

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Changes
    • Crafting station status now shows recipe and ingredient progress without listing configured hit names or counts.
    • Players are informed that they must find the required hits themselves.

Walkthrough

CraftingStation.getStatusLines() no longer shows configured hit counts. It retains recipe and material progress lines. Tests now check the updated output.

Changes

Crafting station status output

Layer / File(s) Summary
Status output and test expectations
src/main/java/net/tfminecraft/advancedcrafting/objects/crafting/CraftingStation.java, src/test/java/net/tfminecraft/advancedcrafting/*CoverageTest.java
getStatusLines() no longer includes hit counts. Tests expect recipe and material progress lines without hit entries.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Suggested reviewers: ryanbarlow97

Merge Risk: ⚪ Minimal · up to 576af

The status display change matches the stated behavior, and the supplied test summaries remain aligned with it. No actionable merge-blocking risk is evident.

  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai

coderabbitai Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@XxFran10xX
XxFran10xX merged commit f474304 into main Oct 8, 2026
2 checks passed
@XxFran10xX
XxFran10xX deleted the fix/branding-status-no-spoilers branch October 8, 2026 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant