Repository navigation
fix: stop the branding status listing hit counts - #35
Conversation
The branding tool's right-click status listed how often each configured hit had been used, which helps players track the hit split they are meant to work out themselves. It now shows only the recipe, the material groups still to fill and how to finish or cancel. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@coderabbitai review |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (3)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 SummarySummary by CodeRabbit
Walkthrough
ChangesCrafting station status output
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~8 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The status display change matches the stated behavior, and the supplied test summaries remain aligned with it. No actionable merge-blocking risk is evident.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Action performedReview finished.
|
Why
Players are meant to work out each recipe's hit split themselves, and only the finished item's percent should tell them how they did. #34 made the branding tool's right-click status list how many times each configured hit had been used. That turns it into a tracker for exactly what players are supposed to work out.
Changes
CraftingStation.getStatusLines()now shows only the recipe name, the material groups (Metal: 1/2, the same as the add-material title) and the finish/cancel lines. The per-hit counts are gone.HitLoaderchange stays:map.clear()on reload keeps removed hits from lingering.hit-overshoot-warn-*config) is unchanged.Tests
StationCoverageTest.statusLinesShowMaterialsButNoHitCountschecks that recorded hits never show up in the status.mvn verifypasses locally, apart fromEdgeCoverageTestandStationDatabaseCoverageTest. Their file-permission/temp-dir tests fail on Windows onmaintoo, so CI covers them.CraftingStationandCraftingManagerstay at 100% coverage.🤖 Generated with Claude Code