Skip to content

chore: remove legacy CI flag and declare API 1.21.10 - #19

Merged
ryanbarlow97 merged 2 commits into
mainfrom
chore/remove-legacy-references
Sep 24, 2026
Merged

ryanbarlow97 merged 2 commits into
mainfrom
chore/remove-legacy-references

Conversation

@ryanbarlow97

@ryanbarlow97 ryanbarlow97 commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Remove -P'!deploy-live' from the Maven commands. No POM defines a deploy-live profile, so the flag does nothing.
  • plugin.yml: api-version 1.21 → 1.21.10, matching the shared baseline and every other plugin.

Verification

  • The build workflow runs on this PR. The release workflow gets the same edits but only runs on tags.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Compatibility

    • Updated the declared Minecraft API version to 1.21.10.
  • Build and Release

    • Maven version, packaging, and verification steps now use the default active profiles, including in build and release workflows. This may affect which profile-specific behavior runs during those steps.

ryanbarlow97 and others added 2 commits September 24, 2026 20:45
No POM defines a deploy-live profile, so -P'!deploy-live' does nothing.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Match the shared Java 21 / Minecraft 1.21.10 baseline used by every
other plugin descriptor.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 337c0579-ddc1-40d6-ab6a-9e85f205c021

📥 Commits

Reviewing files that changed from the base of the PR and between 586b46b and 10a62c4.

📒 Files selected for processing (3)
  • .github/workflows/build.yml
  • .github/workflows/maven-release.yml
  • src/main/resources/plugin.yml

Included review availability: Your plan provides up to 10 included reviews per hour; 6 remain after this review.


📝 Walkthrough

Walkthrough

The build and release workflows now run Maven commands with the default active profiles. The plugin descriptor now declares Minecraft API version 1.21.10.

Changes

Maven profile selection

Layer / File(s) Summary
Default Maven profile selection
.github/workflows/build.yml, .github/workflows/maven-release.yml
The workflow commands no longer disable the deploy-live profile. They use Maven’s default active profiles.

Plugin API version

Layer / File(s) Summary
Plugin API declaration
src/main/resources/plugin.yml
The declared Minecraft API version changes from 1.21 to 1.21.10.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 10a62

The workflows remove an exclusion for a profile not defined in the repository, and the plugin API declaration matches the project’s Paper API version. No concrete merge-blocking behavior is established by the reviewed configuration.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes both primary changes: removing the legacy CI flag and declaring Minecraft API version 1.21.10.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

A rabbit checks the build by moonlit glow,
Maven keeps the profiles it would normally show.
The plugin’s version hops to one-two-one-ten,
Then the rabbit checks the release build again.
It nibbles a carrot and bounds through the snow.

Comment @coderabbitai help to get the list of available commands.

@ryanbarlow97
ryanbarlow97 merged commit 9873df5 into main Sep 24, 2026
2 checks passed
@ryanbarlow97
ryanbarlow97 deleted the chore/remove-legacy-references branch September 24, 2026 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant