Repository navigation
build: align pom.xml with TFMC POM conventions - #24
Conversation
Reformat to four-space indentation with the HTTPS Maven XSD, order the top-level sections as Docs POM-CONVENTIONS.md describes, add the project URL, keep maven.compiler.release as the single Java target and declare maven-compiler-plugin 3.14.1 explicitly. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 4 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughThe POM reorganises project metadata and dependencies, defines resource handling, configures compiler and test plugins, and retains the ChangesMaven build configuration
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to This change reorganizes the Maven build configuration and keeps the Java 21 target. The reported full verify run passed, so merge risk is minimal. The opt-in pack-api-tests profile was not run locally. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
Comment |
Summary
Brings
pom.xmlin line with Docs POM-CONVENTIONS.md. Archaeo was the last plugin POM not following them.name, newurl), properties, dependencies, repositories, build, profiles. Repositories previously came before dependencies, and profiles came before build.maven.compiler.release(21) first andproject.build.sourceEncodingsecond. Removed the redundantmaven.compiler.sourceandmaven.compiler.target.maven-compiler-pluginis now declared explicitly at the common TFMC version3.14.1, first in the build plugins. Before this change Maven 3.9.11 used its implicit default, 3.13.0.pack-api-testsprofile are unchanged.Known deviation: coordinates
groupIdcom.nowkoandartifactIdarcheology-plugin, along with<name>archeology-plugin</name>, are deliberately unchanged. Other repositories consume these coordinates:activity-tf/pom.xmlandtlibs/tools/plugins.json. Moving tonet.tfminecraftcoordinates would need a coordinated migration across those repositories, so it is left for a separate change.Checks
maven-help-plugin:3.5.2:effective-pom, offline, using Maven 3.9.11 and JDK 21. I ran the comparison twice: once with the default profiles and once with-Ppack-api-tests. In both runs the only differences were:urladded;maven.compiler.sourceandmaven.compiler.targetremoved;maven-compiler-pluginchanged from the implicit 3.13.0 to the explicit 3.14.1, and its entry moved in the effective plugin list. Its executions and configuration are the same.mvn -o clean verifypassed: 684 tests, 0 failures, 0 errors, 0 skipped. The build compiled withcompiler:3.14.1, and the JaCoCo report andarchaeo-main-SNAPSHOT.jarwere produced as before.pack-api-testsprofile, because its private pack-plugin jars are not available locally. Its effective POM is unchanged apart from the differences listed above.🤖 Generated with Claude Code