Skip to content

chore: vary goldsmithing recipes that shared a gold mix - #27

Merged
XxFran10xX merged 1 commit into
mainfrom
chore/vary-goldsmith-recipes
Sep 27, 2026
Merged

XxFran10xX merged 1 commit into
mainfrom
chore/vary-goldsmith-recipes

Conversation

@XxFran10xX

@XxFran10xX XxFran10xX commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

Projects in each tier all used the same gold combination. Each tier keeps one project on the old mix; the others now use a slightly different mix. Every project still needs the same total gold for its tier (minor 4, lesser 6, major 8, greater 10).

Tier Project Rough Moldable Shiny
minor gold_ring 4
minor red_necklace 3 1
minor green_medal 3 1
minor blue_medal 2 2
lesser jeweled_gold_ring 3 3
lesser purple_necklace 4 2
lesser mirror 2 4
major purple_ring 2 4 2
major dark_necklace 3 3 2
major chalice 2 3 3
greater red_ring 4 6
greater green_ring 5 5
greater pendant 3 7
greater bracelet 1 4 5

The project menu only shows total gold per type, so it looks the same to players. The exact mix affects the recipe % and the hits needed.

Tested on TFMCDev01: copied the file and ran geminfusion reload. No loader warnings.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Updates
    • Adjusted the required amounts of rough, moldable, and shiny gold for several goldsmithing recipes, including rings, necklaces, a pendant, medals, a mirror, a chalice, and a bracelet. Item names, tiers, and gem requirements are unchanged.

Projects in the same tier all used the same gold combination. Each tier
keeps one project on the old mix; the others now use a slightly different
mix with the same total gold.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: c45a2cea-2d2f-4086-9371-6743261c3b8d

📥 Commits

Reviewing files that changed from the base of the PR and between ee3e4dd and 011b6b6.

📒 Files selected for processing (1)
  • src/main/resources/goldsmithing/projects.yml

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

Gold quantities changed in ten recipes in the goldsmithing project data. Item names, IDs, tiers, and gem requirements remain unchanged.

Changes

Goldsmithing Recipes

Layer / File(s) Summary
Recipe quantity updates
src/main/resources/goldsmithing/projects.yml
Gold quantities changed for the green ring, necklaces, pendant, medals, mirror, chalice, and bracelet.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Suggested reviewers: carolinebondhus

Merge Risk: ⚪ Minimal · up to 011b6

The recipes rebalance gold types without changing their total gold or gem requirements. No concrete merge-blocking risk is identified; the change appears ready under normal checks.

Architecture Summary

Architecture risk: 🔵 Low · up to 011b6

The change affects 1 system.

Changed systems: src

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — src (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in src/main/resources/goldsmithing/projects.yml: The green ring recipe now uses 5 moldable gold and 5 shiny gold instead of 4 and 6, respectively.
  • observed — Modified behavior in src/main/resources/goldsmithing/projects.yml: The red necklace recipe now uses 3 rough gold and adds 1 moldable gold; previously it used 4 rough gold only.
  • observed — Modified behavior in src/main/resources/goldsmithing/projects.yml: The purple necklace recipe now uses 4 rough gold and 2 moldable gold instead of 3 and 3.
  • observed — Modified behavior in src/main/resources/goldsmithing/projects.yml: The dark necklace recipe now uses 3 rough gold and 3 moldable gold instead of 2 and 4; its 2 shiny gold remain unchanged.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: varying goldsmithing recipes that previously shared the same gold mix.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

A rabbit counts each golden piece,
Rough and moldable, set with care.
Shiny gold joins the recipe,
Ten small changes now sit there.
The rabbit hops beneath the moon,
And dreams of gold by afternoon.

Comment @coderabbitai help to get the list of available commands.

@XxFran10xX
XxFran10xX merged commit 1f8d1d6 into main Sep 27, 2026
2 checks passed
@XxFran10xX
XxFran10xX deleted the chore/vary-goldsmith-recipes branch September 27, 2026 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant