Skip to content

fix: reword player messages in character - #30

Merged
ryanbarlow97 merged 1 commit into
mainfrom
copy/rp-wording
Oct 1, 2026
Merged

ryanbarlow97 merged 1 commit into
mainfrom
copy/rp-wording

Conversation

@ryanbarlow97

Copy link
Copy Markdown
Contributor

Summary

Rewords player-facing gameplay messages that broke immersion with server terms (permissions, access, containers, entities, chunks, plugin names) so they read in character. Staff and admin commands, usage help and setup errors keep their plain wording. Wording only: no permission checks or message routing change.

All four skill checks share one constant, Permissions.NOT_SKILLED_GOLDSMITH.

Before and after

Colour codes are omitted; the code keeps them.

Before After
You do not have permission to use goldsmithing. You are not skilled enough to practise goldsmithing.
You already have the needed amount of this type The piece already has enough of that material
This item type is not needed for the project This piece does not call for that material
This item cannot be used for goldsmithing hits You cannot work the piece with that tool

Testing

mvn -o verify passes: 99 tests, 0 failures.

🤖 Generated with Claude Code

Replace out-of-character wording in gameplay messages (permissions,
containers, entities, chunks, plugin tags) with in-world phrasing.
Staff commands, usage help and setup errors keep their plain wording.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 0028fe9e-7791-4a0f-b41b-f2bd27bfeeec

📥 Commits

Reviewing files that changed from the base of the PR and between ed393f8 and c1d2acd.

📒 Files selected for processing (3)
  • src/main/java/net/tfminecraft/geminfusion/Permissions.java
  • src/main/java/net/tfminecraft/geminfusion/goldsmith/GoldsmithStationManager.java
  • src/test/java/net/tfminecraft/geminfusion/goldsmith/GoldsmithStationManagerTest.java

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 0 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Bug Fixes
    • Goldsmith access-denial messages now clearly state that the player is not skilled enough to use the station, including when interacting with its menu.
    • Messages about excess materials, material types that are not needed, and invalid tools have been reworded. The outcomes for these situations remain unchanged.

Walkthrough

Goldsmith access denials now use a shared message constant in permission checks and station interactions. Feedback for excess materials, unneeded materials, and invalid tools has revised wording. Permission-denial tests now check the exact message.

Changes

Goldsmith messages

Layer / File(s) Summary
Goldsmith message updates
src/main/java/net/tfminecraft/geminfusion/Permissions.java, src/main/java/net/tfminecraft/geminfusion/goldsmith/GoldsmithStationManager.java, src/test/java/net/tfminecraft/geminfusion/goldsmith/GoldsmithStationManagerTest.java
A shared constant replaces goldsmith access-denial messages. Material and tool feedback wording changes. The permission-denial tests assert the exact message.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to c1d2a

Goldsmith denials now use profession-specific wording, while the interaction behavior remains unchanged. No material merge risk is established.

  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Comment @coderabbitai help to get the list of available commands.

@ryanbarlow97
ryanbarlow97 merged commit 095243a into main Oct 1, 2026
2 checks passed
@ryanbarlow97
ryanbarlow97 deleted the copy/rp-wording branch October 1, 2026 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant