Skip to content

fix: reword player messages in character - #28

Merged
ryanbarlow97 merged 1 commit into
mainfrom
copy/rp-wording
Oct 1, 2026
Merged

ryanbarlow97 merged 1 commit into
mainfrom
copy/rp-wording

Conversation

@ryanbarlow97

Copy link
Copy Markdown
Contributor

Summary

Rewords player-facing gameplay messages that broke immersion with server terms (permissions, access, containers, entities, chunks, plugin names) so they read in character. Staff and admin commands, usage help and setup errors keep their plain wording. Wording only: no permission checks or message routing change.

Before and after

Colour codes are omitted; the code keeps them.

Before After
Lacking inputs You lack the materials for this weapon.
Class conflict! These parts have incompatible class requirements: These parts cannot go together. They are made for different callings:
No compatible skin No known design fits these parts

Testing

mvn -o verify passes: 162 tests, 0 failures.

🤖 Generated with Claude Code

Replace out-of-character wording in gameplay messages (permissions,
containers, entities, chunks, plugin tags) with in-world phrasing.
Staff commands, usage help and setup errors keep their plain wording.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 15725e48-54f4-43e8-9b93-81b7c2ccb1e9

📥 Commits

Reviewing files that changed from the base of the PR and between 19c88a7 and 29ec198.

📒 Files selected for processing (3)
  • src/main/java/net/tfminecraft/gunsandgadgets/manager/CraftingManager.java
  • src/main/java/net/tfminecraft/gunsandgadgets/manager/inventory/InventoryManager.java
  • src/test/java/net/tfminecraft/gunsandgadgets/manager/CraftingManagerTest.java

Limit details: You’ve used all 10 included reviews currently available.


📝 Summary

Summary by CodeRabbit

  • User-Facing Updates
    • Clarified the message shown when you lack the materials to craft a weapon.
    • Updated messages for incompatible weapon parts and when no suitable design is available.

Walkthrough

Three player-facing messages now use revised wording for insufficient crafting materials, conflicting class requirements, and parts with no known design. The crafting test now expects the revised insufficient-materials message.

Changes

Player-facing messages

Layer / File(s) Summary
Update player-facing messages
src/main/java/net/tfminecraft/gunsandgadgets/manager/CraftingManager.java, src/test/java/net/tfminecraft/gunsandgadgets/manager/CraftingManagerTest.java, src/main/java/net/tfminecraft/gunsandgadgets/manager/inventory/InventoryManager.java
The insufficient-materials message and its test expectation use revised wording. The class-conflict and missing-design messages also use revised wording. The existing barrier-item behaviour remains unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 29ec1

This PR updates player-facing wording while preserving the described crafting rejection and inventory fallback behavior. No concrete merge risk is apparent.

  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.

Usage-based review receipt

  • Mode: Continue automatically
  • Reviewed files: 3
  • Waived: $0.75 (charged $0.00)
  • View usage details

Note

This review exceeded your plan’s limits and used usage-based reviews—free during trial, billed after paid activation unless disabled. Manage usage-based reviews.


Comment @coderabbitai help to get the list of available commands.

@ryanbarlow97
ryanbarlow97 merged commit 2d3cdd3 into main Oct 1, 2026
2 checks passed
@ryanbarlow97
ryanbarlow97 deleted the copy/rp-wording branch October 1, 2026 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant