Repository navigation
Keep the timelapse panel's scrollbar under its step bar - #117
Merged
Merged
Conversation
The steps were a sticky bar inside the panel's scroller, so the scrollbar ran beside them and up into the panel's rounded corner. They now sit in a header slot above the scroller, like the footer below it. Chrome also ignored the themed ::-webkit-scrollbar rules because the standard scrollbar-width/scrollbar-color were set for every browser, and drew its plain native bar with arrow buttons. The standard properties now apply only where ::-webkit-scrollbar is unsupported (Firefox). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 53 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
On the timelapse studio's panel (desktop Chrome), the scrollbar:
Changes
MapShell: the details panel gets adetailsHeaderslot, pinned above the scrolling body (the counterpart ofdetailsFooter).pt-4in place of the bar's oldmb-4.globals.css:scrollbar-width/scrollbar-colornow apply only under@supports not selector(::-webkit-scrollbar)(Firefox). Since Chrome 121, setting the standard properties makes Chrome ignore every::-webkit-scrollbarrule. Chrome and Safari now use the themed 8 px rounded bar with no arrows. Side effect:[scrollbar-width:none]on the drill breadcrumb now takes effect in Chrome, as intended.Checks
tsc --noEmitclean.vitest run: 1,949 pass.RecipeVehiclePreview.test.tsxtimes out on this host, and fails the same way on unchangedmain.🤖 Generated with Claude Code