Repository navigation
Hide the page scrollbar on touch screens - #187
Merged
Merged
Conversation
The themed ::-webkit-scrollbar rules applied everywhere, so phones drew a grey bar down the page edge and an 8px track in every inner scroller. They now apply to mouse and trackpad devices only. On touch screens the page has no scrollbar, and inner scrollers keep the browser's own fading bar. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 57 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phones no longer show a scrollbar down the side of the page.
What changes
::-webkit-scrollbarrules (and the Firefoxscrollbar-width/scrollbar-colorfallback) inglobals.cssnow sit inside@media (hover: hover) and (pointer: fine), so only mouse and trackpad devices get them. Desktop looks the same.(pointer: coarse)the page itself has no scrollbar (html { scrollbar-width: none }plushtml::-webkit-scrollbar { display: none }).Testing
--hide-scrollbarsremoved), old vs new CSS on a long page with an inner scroller:npx oxfmt --check app/internal/globals.csspasses.Follow-up to #185.
🤖 Generated with Claude Code