fix: prevent lockpicking accessible containers

[ryanbarlow97]

Players could lockpick containers they could already open because the shipped debug setting skipped the access check. Normal container lockpicking now always applies the same single/double chest access rules as opening, including owner, public, guild, faction and staff access. The separate staff test command remains available, and the config comment clarifies that the old debug option now applies only to displays.

Validation: tfmc-mvn -o -B --no-transfer-progress clean verify passed 1,028 tests with zero failures, errors or skips and all 100% coverage gates. Includes 24 new access/debug regression cases; eight Python rollback tests, report validation and runtime JAR validation also passed. Sol review found no actionable issues.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 81fcf88f-f633-4a28-b682-b840eed272e0

📥 Commits

Reviewing files that changed from the base of the PR and between 0f7fc84 and 614b866.

📒 Files selected for processing: 3

• src/main/java/net/tfminecraft/thievery/door/ContainerManager.java
• src/main/resources/config.yml
• src/test/java/net/tfminecraft/thievery/door/ContainerManagerTest.java

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Summary

Summary by CodeRabbit

• Bug Fixes
  • Lockpicking is now denied when you already have access to a container, including both halves of a double chest. These attempts stop before clues or the lockpicking challenge.
• Documentation
  • Clarified that display lockpick testing applies only to display locks; use /thievery testpick for containers.

Lockpicking now stops when a player can already access the target container. The check applies regardless of the debug setting and accounts for both halves of a double chest. Tests cover access rules and confirm that later lockpicking operations do not run.

Changes: Container lockpicking

Layer / File(s)	Summary
Accessible-container check and test coverage src/main/java/net/tfminecraft/thievery/door/ContainerManager.java, src/test/java/net/tfminecraft/thievery/door/ContainerManagerTest.java, src/main/resources/config.yml	The access check rejects lockpick attempts when the player can access a single container or both halves of a double chest. Parameterised tests cover access types and both debug settings. The config comment directs container lockpick testing to /thievery testpick.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: drefvelin

Merge Risk: ⚪ Minimal · up to 614b8

No merge-blocking issue is identified; proceed with normal checks.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}