Setup method will accept element not the id of element.

TIPOFF · Apr 29, 2021 · 5a2cc47 · 5a2cc47
1 parent 41779be
commit 5a2cc47
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 12 deletions.
diff --git a/dist/js/field.js b/dist/js/field.js
diff --git a/resources/js/address.js b/resources/js/address.js
@@ -26,8 +26,8 @@ const Address = (function () {
 
     let autocompleteService;
     let placesService;
-    let predictionListElementId;
-    let placeElementId;
+    let predictionListElement;
+    let placeElement;
 
     let resetSessionToken = function () {
         let sessionToken = new google.maps.places.AutocompleteSessionToken();
@@ -38,7 +38,7 @@ const Address = (function () {
 
     window.initGoogleMapAutocomplete = function () {
         autocompleteService = new google.maps.places.AutocompleteService();
-        placesService = new google.maps.places.PlacesService(document.getElementById(placeElementId));
+        placesService = new google.maps.places.PlacesService(placeElement);
 
         resetSessionToken();
     };
@@ -124,11 +124,11 @@ const Address = (function () {
     };
 
     let showPredictions = function () {
-        document.getElementById(predictionListElementId).classList.remove('invisible');
+        predictionListElement.classList.remove('invisible');
     };
 
     let hidePredictions = function () {
-        document.getElementById(predictionListElementId).classList.add('invisible');
+        predictionListElement.classList.add('invisible');
     };
 
     let addGoogleMapScript = function (key) {
@@ -143,8 +143,8 @@ const Address = (function () {
 
     let setup = function (settings) {
         // Assign essential element.
-        predictionListElementId = settings.predictionListElementId;
-        placeElementId = settings.placeElementId;
+        predictionListElement = settings.predictionListElement;
+        placeElement = settings.placeElement;
 
         // Add Google Map script.
         addGoogleMapScript(settings.googleApiKey);

diff --git a/resources/js/components/Address/FormField.vue b/resources/js/components/Address/FormField.vue
@@ -97,8 +97,8 @@ export default {
 
             places.setup({
                 googleApiKey: Nova.config.googleMapApiKey,
-                predictionListElementId: 'results-list',
-                placeElementId: 'attributions'
+                predictionListElement: document.getElementById('results-list'),
+                placeElement: document.getElementById('attributions')
             });
 
             this.placesAutocomplete = places;

diff --git a/resources/views/domestic-address-search-bar-javascript.blade.php b/resources/views/domestic-address-search-bar-javascript.blade.php
@@ -17,8 +17,8 @@ class="w-full px-2 py-1 focus:outline-none text-gray-700 ring-1 ring-gray-300 ro
         window.onload = function () {
             Address.setup({
                 googleApiKey: '{{ config('google-api.services.places.key') }}',
-                predictionListElementId: 'results-list',
-                placeElementId: 'attributions'
+                predictionListElement: document.getElementById('results-list'),
+                placeElement: document.getElementById('attributions')
             });
 
             const addressInput = document.getElementById('search-bar');