player-use-pertick-interpolated

[silnarm]

• add player position/rotation interpolation to perTick use action

[silnarm]

perTick test 1_14_4 (read-only).zip
Script should be stopping the bot before killing, in some versions the momentum carries over on respawn and messes up test reruns.

/script load pertick_test
/script in pertick_test invoke reset
/script in pertick_test invoke run_test
... wait for bot to be killed (unless something goes wrong) ...
/script in pertick_test invoke report

[Fallen-Breath]

Does it only support "USE" action pack? imo it's much better if all action packs support interpolation
at the same time, and them will have the same behavior

[silnarm]

added to ATTACK as well.

[Fallen-Breath]

You can use the global flag suggestion described in 2. of #119 (comment), so you don't need to mixin into every action implemetation that invokes EntityPlayerActionPack#getTarget

[Fallen-Breath]

@Redirect is bad, try use @ModifyExpressionValue or @WrapOperation from mixin extra, or set require = 0 if you do need an @Redirect

[silnarm]

Yes, bad I know. It is carpet code at least, not MC. Added the require = 0, but I was unable to get rid of it, @ModifyExpressionValue gave an unhelpful error message, but I assume the static function is the problem.

[Fallen-Breath]

Some suggestions:

1. Store the posLastTick stuffs inside EntityPlayerActionPack instead of storing in ServerPlayerEntityMixin
   • It's for tweaking the action pack, then place it inside the action pack
   • It's also a per-player object
2. Use ThreadLocal to store your extra custom argument (tickPart) to alternate the logics inside carpet.script.utils.Tracer#rayTrace, then do @ModifyArg inside the rayTrace method
   • A more proper (and suggested iirc.) way to pass a custom variable, in cause multiple EntityPlayerActionPack run at the same time
   • Then you can just set / clear the ThreadLocal at the beginning / end of the perTickMultiplier multiplier logic

[Fallen-Breath]

So here's where you record the rotation and position of the player:

• when the action starts
• when the action completes an execution

You're assuming that the player moves smoothly between 2 positions, but this assution might be wrong. The player might be teleported, and teleporation do not have interpolation

[silnarm]

This is true. I had largely discounted it as an issue originally because player reach meant the use attempts would do nothing anyway, but it will potentially load chunks which does suck.
Will have a think about it, seems like it will be a few more injects at least though, I'm not convinced it is worth handling this explicitly.

[Fallen-Breath]

imo, it's important to ensure interpolation only applies in the correct scenarios. As you mentioned, interpolating in unexpected scenarios can cause problems, especially since carpet doesn't provide fine-granular permission system for these commands

and that's why the interpolation feature is hard to implement