Skip to content

Move import plan validation after processing #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PaulFarault merged 1 commit into from
Dec 18, 2025
Merged

Move import plan validation after processing #704

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 11 additions & 12 deletions tdp/cli/commands/plan/import_file.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,20 +36,19 @@ def import_file(
from tdp.core.models.enums import DeploymentStateEnum
from tdp.dao import Dao

with Dao(db_engine, commit_on_exit=True) as dao:
with open(file_name) as file:
# Remove empty elements and comments
# and get the operations, hosts and extra vars in a list
new_operations_hosts_vars = parse_file(file)
if not new_operations_hosts_vars:
raise click.ClickException("Plan must not be empty.")
deployment = DeploymentModel.from_operations_hosts_vars(
collections, new_operations_hosts_vars
)
with open(file_name) as file:
# Remove empty elements and comments
# and get the operations, hosts and extra vars in a list
new_operations_hosts_vars = parse_file(file)
if not new_operations_hosts_vars:
raise click.ClickException("Plan must not be empty.")
deployment = DeploymentModel.from_operations_hosts_vars(
collections, new_operations_hosts_vars
)
with Dao(db_engine, commit_on_exit=True) as dao:
if last_deployment := dao.get_last_deployment():
validate_plan_creation(last_deployment.state, force)
if last_deployment.state is DeploymentStateEnum.PLANNED:
deployment.id = last_deployment.id
dao.session.merge(deployment)
dao.session.commit()
click.echo("Deployment plan successfully imported.")
click.echo("Deployment plan successfully imported.")