All methods on models as pointer receivers #1325
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Testserver will be ready at https://1325.test.live.mm.rbg.tum.de in a few minutes. Logins
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fixes #1272.
In the model package many structs have methods on both value and pointer receivers. Having mixed receivers is for consistencies sake not ideal, but since many of these structs are also quite large, and using value receivers implies copying data, using pointer receivers would be slightly more performant.
Description
Any value receivers were changed to pointer receivers, usually this was as simple as changing the signature. Any superfluous receivers were also removed.
Steps for Testing
Nothing should have changed.
Screenshots