Feature/typo3 v14 compatibility#878
Open
chrisprog20 wants to merge 3 commits intoTYPO3-Headless:feature/typo3-v14from
Open
Feature/typo3 v14 compatibility#878chrisprog20 wants to merge 3 commits intoTYPO3-Headless:feature/typo3-v14from
chrisprog20 wants to merge 3 commits intoTYPO3-Headless:feature/typo3-v14from
Conversation
Prevent fatal error: Fatal error: Declaration of FriendsOfTYPO3\Headless\Seo\MetaTag\AbstractMetaTagManager::renderProperty(string $property): string must be compatible with TYPO3\CMS\Core\MetaTag\AbstractMetaTagManager::renderProperty(string $property, ?TYPO3\CMS\Core\Type\DocType $docType = null): string
Used rector config
return RectorConfig::configure()
->withPaths([
__DIR__ . '/vendor/friendsoftypo3/headless',
])
// uncomment to reach your current PHP version
// ->withPhpSets()
->withPhpVersion(PhpVersion::PHP_82)
->withSets([
// Rector rules
//SetList::CODE_QUALITY,
//LevelSetList::UP_TO_PHP_82,
//Typo3SetList::CODE_QUALITY,
//Typo3SetList::GENERAL,
Typo3LevelSetList::UP_TO_TYPO3_14,
// To migrate to Doctrine Dbal 4, uncomment the following line
\Rector\Doctrine\Set\DoctrineSetList::DOCTRINE_DBAL_40,
])
// To have a better analysis from PHPStan, we teach it here some more things
->withPHPStanConfigs([Typo3Option::PHPSTAN_FOR_RECTOR_PATH])
//->withImportNames(true, true, false, true)
->withRules([
AddVoidReturnTypeWhereNoReturnRector::class,
ConvertImplicitVariablesToExplicitGlobalsRector::class,
])
//->withConfiguredRule(ExtEmConfRector::class, [
//ExtEmConfRector::PHP_VERSION_CONSTRAINT => '8.2.0-8.4.99',
//ExtEmConfRector::TYPO3_VERSION_CONSTRAINT => '14.0.0-14.3.99',
//ExtEmConfRector::ADDITIONAL_VALUES_TO_BE_REMOVED => [],
//])
->withConfiguredRule(
RemoveTypo3VersionChecksRector::class,
[RemoveTypo3VersionChecksRector::TARGET_VERSION => 14]
)
->withSkip([
// @see sabbelasichon/typo3-rector#2536
__DIR__ . '/**/Configuration/ExtensionBuilder/*',
NameImportingPostRector::class => [
'ClassAliasMap.php',
]
])
;
For the TYPO3 14 rules set also the T3 14 TCA rule set has been applied and the T3 14.2 rule set.
…ervice cannot extend readonly class TYPO3\CMS\Extbase\Service\ImageService'
twoldanski
reviewed
Apr 15, 2026
| /** | ||
| * @codeCoverageIgnore | ||
| */ | ||
| readonly class PreviewController extends \TYPO3\CMS\Workspaces\Controller\PreviewController |
Collaborator
There was a problem hiding this comment.
this xclass will be problematic if someone has workspaces installed, in TYPO3 v14 this class is final, so should remove this xclass, and find workaround for maintaining this feature in v14
twoldanski
requested changes
Apr 15, 2026
Collaborator
twoldanski
left a comment
twoldanski
left a comment
There was a problem hiding this comment.
Thanks for PR, looks good to me, only we have to drop xclass for time being
Author
|
@twoldanski You're welcome. So you care about the dropping of the xclass, right? I have no clue at the moment how to solve this. Or could you give me a hint? |
Collaborator
|
@chrisprog20 drop it, for now we can't do anything with it really, we have to collaborate with core team to introduce some event to handle this case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first and third commit below prevent errors during a composer require of friendsoftypo3/headless in main branch of TYPO3. The second commit applied rector to make the extension compatible with current main branch of TYPO3. They serve to be able to run the headless extension in a TYPO3 14.3 LTS installation.