Skip to content

Make default debounce time 0.5 seconds #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tudddorrr merged 1 commit into from
Aug 5, 2026
Merged

Make default debounce time 0.5 seconds #236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion addons/talo/talo_settings.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ var cache_player_on_identify: bool:
## Number of seconds to wait before sending debounced requests (e.g. player updates, save updates and health checks)
var debounce_timer_seconds: float:
get:
return _config_file.get_value("", "debounce_timer_seconds", 1.0)
return _config_file.get_value("", "debounce_timer_seconds", 0.5)
set(value):
_config_file.set_value("", "debounce_timer_seconds", value)

Expand Down
6 changes: 3 additions & 3 deletions test/settings/talo_settings_test.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,8 +234,8 @@ func test_cache_player_on_identify_writing() -> void:

# debounce_timer_seconds

func test_debounce_timer_seconds_defaults_to_1() -> void:
assert_float(Talo.settings.debounce_timer_seconds).is_equal(1.0)
func test_debounce_timer_seconds_defaults_to_0point5() -> void:
assert_float(Talo.settings.debounce_timer_seconds).is_equal(0.5)

func test_debounce_timer_seconds_reading() -> void:
var file := ConfigFile.new()
Expand All @@ -249,7 +249,7 @@ func test_debounce_timer_seconds_writing() -> void:
Talo.settings.save_config()
var file := ConfigFile.new()
file.load(TaloSettings.SETTINGS_PATH)
assert_float(file.get_value("", "debounce_timer_seconds", 1.0)).is_equal(2.5)
assert_float(file.get_value("", "debounce_timer_seconds", 0.5)).is_equal(2.5)

# verification_enabled

Expand Down