perf(react-form): skip updating isValidating by default #1291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: isValidating is now opt-in
|
Unsure if this is even the right direction, as it's essentially flipping an established default purely for react performance. |
MVaik
commented
Mar 16, 2025
There was a problem hiding this comment.
"should properly update conditionally rendered fields" is now failing after this change, the "hello" that is written into firstField somehow ends up in secondField after the checkbox is toggled and firstField is no longer shown. This turns secondField into "helloworld" instead of "world".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1130
BREAKING CHANGE: isValidating is now opt-in