Skip to content

Conversation

Vijayabaskar56
Copy link

@Vijayabaskar56 Vijayabaskar56 commented Sep 30, 2025

🎯 Changes

Add the withFieldGroup API for Form Composition in Solid Form

βœ… Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm test:pr.

πŸš€ Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

Copy link

changeset-bot bot commented Sep 30, 2025

πŸ¦‹ Changeset detected

Latest commit: 71b7a35

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@tanstack/solid-form Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

nx-cloud bot commented Sep 30, 2025

View your CI Pipeline Execution β†— for commit 71b7a35

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... βœ… Succeeded 45s View β†—
nx run-many --target=build --exclude=examples/** βœ… Succeeded 8s View β†—

☁️ Nx Cloud last updated this comment at 2025-10-02 12:50:20 UTC

Copy link

pkg-pr-new bot commented Oct 1, 2025

More templates

@tanstack/angular-form

npm i https://pkg.pr.new/@tanstack/angular-form@1783

@tanstack/form-core

npm i https://pkg.pr.new/@tanstack/form-core@1783

@tanstack/form-devtools

npm i https://pkg.pr.new/@tanstack/form-devtools@1783

@tanstack/lit-form

npm i https://pkg.pr.new/@tanstack/lit-form@1783

@tanstack/react-form

npm i https://pkg.pr.new/@tanstack/react-form@1783

@tanstack/react-form-devtools

npm i https://pkg.pr.new/@tanstack/react-form-devtools@1783

@tanstack/solid-form

npm i https://pkg.pr.new/@tanstack/solid-form@1783

@tanstack/svelte-form

npm i https://pkg.pr.new/@tanstack/svelte-form@1783

@tanstack/vue-form

npm i https://pkg.pr.new/@tanstack/vue-form@1783

commit: 71b7a35

Copy link

codecov bot commented Oct 2, 2025

Codecov Report

βœ… All modified and coverable lines are covered by tests.
βœ… Project coverage is 95.23%. Comparing base (6892ed0) to head (71b7a35).
⚠️ Report is 23 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1783      +/-   ##
==========================================
+ Coverage   90.35%   95.23%   +4.88%     
==========================================
  Files          38        4      -34     
  Lines        1752      105    -1647     
  Branches      444        7     -437     
==========================================
- Hits         1583      100    -1483     
+ Misses        149        5     -144     
+ Partials       20        0      -20     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@LeCarbonator
Copy link
Contributor

Looking good! There's one thing that I'm curious about:

#1648 lists a problem with React's implementation of withFieldGroup. Does this implementation also suffer this problem?

@Vijayabaskar56
Copy link
Author

Most likely, but will try to reproduce and let you know

@Vijayabaskar56
Copy link
Author

Vijayabaskar56 commented Oct 16, 2025

@LeCarbonator , I have tested it , first I would thought that, the implementation is same so there is a change , but to my suprise, the bug is not presented in the solid version, then later only realized that solids signal based reactive pattern does not dependent on component state to rerender the component, and state are independent. so case in point , this #1648 issues from react version of withFieldGroup will not be a problem in solid version

@Riddhiman007
Copy link

Wow nice, can't wait for this feature anymore

@LeCarbonator
Copy link
Contributor

@Vijayabaskar56 Sounds good, then! I guess this PR is not blocked by that then. We'll try to review it soon.

@Vijayabaskar56
Copy link
Author

looking forward to it.. 😁.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants