Skip to content

chore(deps): update dependency vite to v5 [security] #9708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

chore(deps): update dependency vite to v5 [security] #9708

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/vue/2.6-basic/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
},
"devDependencies": {
"typescript": "5.8.3",
"vite": "^4.5.14",
"vite": "^5.4.20",
"vite-plugin-vue2": "2.0.3"
Comment on lines 17 to 19
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Upgrade blocked by Vue 2.6 plugin compatibility

Line 17 moves this example to Vite ^5.4.20 while retaining [email protected], but that plugin’s peer constraint is vite ^2 || ^3, so installation will fail and the tooling won’t run.(npmpeer.dev) Compounding that, the package is in maintenance mode and only supports Vue 2.6 or earlier with no Vite 5-ready release, so we either keep this example on Vite 4 or migrate it to Vue 2.7 plus @vitejs/plugin-vue2 before bumping Vite.(npm.io)

🤖 Prompt for AI Agents 
In examples/vue/2.6-basic/package.json around lines 17-19, Vite was bumped to
^5.4.20 but the project still depends on [email protected] which only
supports vite ^2 || ^3 and is not Vite 5 compatible; fix by either (A) pinning
Vite to a Vite-4-compatible version (e.g., ^4.x) so the existing
vite-plugin-vue2 remains valid, or (B) migrate the example to Vue 2.7 and
replace vite-plugin-vue2 with a Vite-5-compatible plugin (e.g.,
@vitejs/plugin-vue2), update package.json and any plugin-related config/code,
then run npm install and smoke-test the dev/build to ensure tooling works.

Comment on lines +18 to 19
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

Vite 5 conflicts with [email protected]

[email protected] declares a peer range of vite ^2 || ^3, so bumping vite to ^5.4.20 causes npm install (and CI) to fail with an unmet peer dependency. Either keep this example on a Vite 4-compatible version, or migrate to Vue 2.7 + @vitejs/plugin-vue2 before jumping to Vite 7.1.9 as per the PR objective.

Run this to confirm the peer constraint:

🏁 Script executed:

#!/bin/bash
npm view [email protected] peerDependencies

Length of output: 77

[email protected] incompatible with Vite 5 in examples/vue/2.6-basic
[email protected] peer-depends on Vite ^2.0.0 || ^3.0.0 || ^4.0.0, so upgrading to "vite": "^5.4.20" breaks installs. Either pin Vite to ^4.x for this example or migrate to Vue 2.7 + @vitejs/plugin-vue2 before bumping to Vite 7.1.9.

🤖 Prompt for AI Agents 
In examples/vue/2.6-basic/package.json around lines 18-19, the current change
updates "vite" to "^5.4.20" while keeping "vite-plugin-vue2": "2.0.3", but that
plugin peer-depends on Vite ^2/3/4 so installs will break; fix by either pinning
Vite back to a compatible ^4.x for this Vue 2.6 example (set vite to a ^4.0.x
range) OR migrate the example to Vue 2.7 and replace vite-plugin-vue2 with
@vitejs/plugin-vue2 and update related deps before bumping Vite to newer major
versions; update package.json accordingly and verify install/build.

}
}
2 changes: 1 addition & 1 deletion examples/vue/2.7-basic/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
},
"devDependencies": {
"typescript": "5.8.3",
"vite": "^4.5.14",
"vite": "^5.4.20",
"vite-plugin-vue2": "2.0.3"
}
}
Loading