Skip to content

Conversation

@phyr0s
Copy link

@phyr0s phyr0s commented May 12, 2017

No description provided.

@Taracque
Copy link
Owner

private is still valid in Swift 3. You can read the difference between private and fileprivate here: https://cocoacasts.com/what-is-the-difference-between-private-and-fileprivate-in-swift-3/
Why you think, that should be changed? I think the reason why your XCode want to update swift code is that Swift Language Version is not defined in the project.

@phyr0s
Copy link
Author

phyr0s commented May 12, 2017

Well Xcode Says that is not updated to Swift 3.

You can create one blank ionic app , add the plugin and cordova build ios. You will see one log saying that is not updated to swift 3

@Taracque
Copy link
Owner

Taracque commented May 12, 2017

Please try to do the same thing with your modifications. For me the same thing happens.
The ionic build ios displays the following message:
“Swift Language Version” (SWIFT_VERSION) is required to be configured correctly for targets which use Swift. Use the [Edit > Convert > To Current Swift Syntax…] menu to choose a Swift version or use the Build Settings editor to configure the build setting directly.
So somehow the SWIFT_VERSION flag needs to set up, to fix this.

@nunovieira
Copy link

I've added cordova-plugin-add-swift-support to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants