Bugfix/initial subgrade modulus api sand#39
Conversation
Reviewer's Guide by SourceryThis pull request fixes bugs in the implementation of the Sørensen sand and Kallehave sand py-curves in the Sequence diagram for py_spring_fct with Kallehave modificationsequenceDiagram
participant API_sand
participant py_curves
participant InitialSubgradeReaction
API_sand->>API_sand: if self.modification == "Kallehave"
API_sand->>InitialSubgradeReaction: kallehave_sand(phi, below_water_table, X, D)
InitialSubgradeReaction-->>API_sand: k
API_sand->>py_curves: api_sand(sig, X, D, kind, below_water_table, k, ymax, output_length)
py_curves-->>API_sand: y, p
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #39 +/- ##
==========================================
- Coverage 51.94% 51.92% -0.02%
==========================================
Files 19 19
Lines 2953 2954 +1
Branches 355 355
==========================================
Hits 1534 1534
- Misses 1333 1334 +1
Partials 86 86 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
openpile.soilmodels.API_sand()led to some minor bugs that are now corrected.Summary by Sourcery
Fix implementation of Sørensen and Kallehave sand py-curves in API_sand() method
Bug Fixes:
Enhancements: