-
Notifications
You must be signed in to change notification settings - Fork 0
[feat/#10] UI Event Provider Setting #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…eam-Kiero/Kiero-Android into feat/#10-core-provider-setting
|
교수님 진도가 너무 빠릅니다 |
…into feat/#10-core-provider-setting # Conflicts: # app/src/main/java/com/kiero/presentation/main/navigation/MainAppState.kt # app/src/main/java/com/kiero/presentation/main/screen/MainScreen.kt
dmp100
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
별미다 별미,,
seungjae708
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다 8주차때 연사님께 배운 PreviewProvider까지 구현하셨네요!!
많이 배워갑니다~~
| class GlobalUiEventHolder( | ||
| val dialogTrigger: DialogTrigger, | ||
| val showToast: (String) -> Unit, | ||
| val showSnackbar: (String, String?, () -> Unit) -> Unit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p1) KieroSnackbar는 액션이 없는 단순 알림용으로 사용하고 있어서 액션 관련 파라미터는 제거하는게 좋을 것 같아요
| val showSnackbar: (String, String?, () -> Unit) -> Unit | |
| val showSnackbar: (String) -> Unit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넵 반영하겠습니다!
| data class SnackbarState( | ||
| val message: String = "", | ||
| val buttonText: String? = null, | ||
| val onActionClick: (() -> Unit)? = null | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p1) 여기도 위랑 마찬가지로 제거해야 될듯요
| } | ||
| } | ||
|
|
||
| val onShowSnackbar: (String, String?, (() -> Unit)?) -> Unit = remember(scope, snackBarHostState) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GlobalUiEventHolder에서는 (String, String?, (() -> Unit)으로 non-nullable한데 여기서는 nullable한 이유가 있나요??
|
잘 보고 갑니다~👍🏻 |
vvan2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
옆에서 같이 확인했습니다.. 대 민 성 수고해쓰요 어푸푸
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고했으요~
dmp100
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
대 민 성
ISSUE
❗ WORK DESCRIPTION
📢 TO REVIEWERS
Flow.collectSideEffect 는 기존의 SideEffect를 처리하는 방식을 확장함수로 사용하기 위해 Wrapping한 함수로 순차처리 방식입니다 따라서 단발성 이벤트인 네비게이션 이동, 토스트, 스낵바, 분석 로그 전송 등에 사용하시면됩니다!
Flow.collectSingleEvent는 위 collectSideEffect 와 마찬가지이나 쓰로틀 방식을 적용하여 0.5초 이내에 들어온 추가 요청은 무시하고 첫번째 클릭만 인정하도록 하여 안정성을 보장합니다
특히 중요한 로그인 버튼, 스플래시에서 부모와 아이 그래프로 이동 시에 사용하면 좋을 것 같습니다
NetworkMonitor를 통해 인터넷을 사용 가능한 와이파이나 데이터에 연결을 모니터링 할 수 있도록 합니다 온라인과 오프라인 상태를 감지 가능합니다
BaseUiStateProvider 로 UiState의 상태 3개를 Preview에서 사용 가능하도록 합니다
EX
나중에 정식으로 확정되면 다시 변경하도록 하겠습니다! 지금은 피그마에 있는 거 가져온거라 그런지 조금 작네요..
📸 SCREENSHOT
🎥 구동 영상
KakaoTalk_20260109_173749147.mp4