-
Notifications
You must be signed in to change notification settings - Fork 0
[init/#1] 프로젝트 초기 세팅 #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 18 commits
a62ddce
a83b665
4b9a5f1
e38213b
0a8e605
b1440b3
dcef7b0
3be7651
18c8d45
d33bbc1
6a58474
f93e3ae
4cd47da
aeb74af
3bf2ce8
f4af73a
ebb312c
d9da6a1
ca48fe9
68d2143
9c42cde
6e16814
56c73a6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| addAssignees: author | ||
|
|
||
| addReviewers: true | ||
|
|
||
| reviewers: | ||
| - vvan2 | ||
| - sonms | ||
| - seungjae708 | ||
| - dmp100 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| name: "Auto Assign and Reviewers" | ||
| on: | ||
| pull_request: | ||
| types: [opened, ready_for_review] | ||
|
|
||
| jobs: | ||
| add-reviewers-and-assignees: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Assign author and add reviewers | ||
| uses: kentaro-m/[email protected] | ||
| with: | ||
| configuration-path: '.github/auto_assign.yml' |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| *.iml | ||
| .gradle | ||
| /local.properties | ||
| /.idea/caches | ||
| /.idea/libraries | ||
| /.idea/modules.xml | ||
| /.idea/workspace.xml | ||
| /.idea/navEditor.xml | ||
| /.idea/assetWizardSettings.xml | ||
| .DS_Store | ||
| /build | ||
| /captures | ||
| .externalNativeBuild | ||
| .cxx | ||
| local.properties |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| /build |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,81 @@ | ||
| import org.jetbrains.kotlin.gradle.dsl.JvmTarget | ||
| import java.util.Properties | ||
|
|
||
| plugins { | ||
| alias(libs.plugins.android.application) | ||
| alias(libs.plugins.jetbrains.kotlin.android) | ||
| alias(libs.plugins.kotlin.compose) | ||
| alias(libs.plugins.dagger.hilt) | ||
| alias(libs.plugins.kotlin.serialization) | ||
| alias(libs.plugins.devtools.ksp) | ||
| } | ||
|
|
||
| val properties = Properties().apply { | ||
| load(project.rootProject.file("local.properties").inputStream()) | ||
| } | ||
|
|
||
|
|
||
| android { | ||
| namespace = "com.Kiero" | ||
| compileSdk = libs.versions.compileSdk.get().toInt() | ||
|
|
||
| defaultConfig { | ||
| applicationId = "com.Kiero" | ||
| minSdk = libs.versions.minSdk.get().toInt() | ||
| targetSdk = libs.versions.targetSdk.get().toInt() | ||
| versionCode = libs.versions.versionCode.get().toInt() | ||
| versionName = libs.versions.versionName.get() | ||
|
|
||
| testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner" | ||
| buildConfigField("String", "BASE_URL", properties["base.url"].toString()) | ||
| } | ||
|
|
||
| buildTypes { | ||
| release { | ||
| isMinifyEnabled = false | ||
| proguardFiles( | ||
| getDefaultProguardFile("proguard-android-optimize.txt"), | ||
| "proguard-rules.pro" | ||
| ) | ||
| } | ||
| } | ||
| compileOptions { | ||
| sourceCompatibility = JavaVersion.VERSION_17 | ||
| targetCompatibility = JavaVersion.VERSION_17 | ||
| } | ||
| kotlin { | ||
| compilerOptions { | ||
| jvmTarget.set(JvmTarget.JVM_17) | ||
| } | ||
| } | ||
| buildFeatures { | ||
| compose = true | ||
| buildConfig = true | ||
| } | ||
| } | ||
|
|
||
| dependencies { | ||
| testImplementation(libs.junit) | ||
| androidTestImplementation(platform(libs.androidx.compose.bom)) | ||
| androidTestImplementation(libs.bundles.test) | ||
|
|
||
| debugImplementation(libs.bundles.debug) | ||
|
|
||
| implementation(libs.bundles.androidx) | ||
| implementation(platform(libs.androidx.compose.bom)) | ||
|
|
||
| implementation(libs.kotlinx.immutable) | ||
|
|
||
| implementation(platform(libs.okhttp.bom)) | ||
| implementation(libs.bundles.okhttp) | ||
| implementation(libs.bundles.retrofit) | ||
| implementation(libs.kotlinx.serialization.json) | ||
|
|
||
| implementation(libs.bundles.hilt) | ||
| ksp(libs.hilt.compiler) | ||
|
|
||
| implementation(libs.coil.compose) | ||
|
|
||
| implementation(libs.timber) | ||
|
|
||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| # Add project specific ProGuard rules here. | ||
| # You can control the set of applied configuration files using the | ||
| # proguardFiles setting in build.gradle. | ||
| # | ||
| # For more details, see | ||
| # http://developer.android.com/guide/developing/tools/proguard.html | ||
|
|
||
| # If your project uses WebView with JS, uncomment the following | ||
| # and specify the fully qualified class name to the JavaScript interface | ||
| # class: | ||
| #-keepclassmembers class fqcn.of.javascript.interface.for.webview { | ||
| # public *; | ||
| #} | ||
|
|
||
| # Uncomment this to preserve the line number information for | ||
| # debugging stack traces. | ||
| #-keepattributes SourceFile,LineNumberTable | ||
|
|
||
| # If you keep the line number information, uncomment this to | ||
| # hide the original source file name. | ||
| #-renamesourcefileattribute SourceFile |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| package com.Kiero | ||
|
|
||
| import androidx.test.platform.app.InstrumentationRegistry | ||
| import androidx.test.ext.junit.runners.AndroidJUnit4 | ||
|
|
||
| import org.junit.Test | ||
| import org.junit.runner.RunWith | ||
|
|
||
| import org.junit.Assert.* | ||
|
|
||
| /** | ||
| * Instrumented test, which will execute on an Android device. | ||
| * | ||
| * See [testing documentation](http://d.android.com/tools/testing). | ||
| */ | ||
| @RunWith(AndroidJUnit4::class) | ||
| class ExampleInstrumentedTest { | ||
| @Test | ||
| fun useAppContext() { | ||
| // Context of the app under test. | ||
| val appContext = InstrumentationRegistry.getInstrumentation().targetContext | ||
| assertEquals("com.Kiero", appContext.packageName) | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p1) 패키지명 대문자인거 같은데 맞을까요..?
이렇게 쓰면 도구들이 패키지가 아니라 com 패키지 안에 있는 Kiero 클래스로 착각하여 버그가 날 수도 있고 전세계적 규칙으로 소문자를 권장합니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p3) 또한 웬만해서는 3단어를 추천합니당
한 번 확인해주시고 판단에 맡기겠습니다~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
헉 컨벤션 정하기 전에 파일 생성한거라 패키지가 대문자로 들어갔네요 ㅜㅜ 확인감사합니다