π :: (#48)- User μλ²ν΅μ μ μν μΈν μ νμ΅λλ€#50
π :: (#48)- User μλ²ν΅μ μ μν μΈν
μ νμ΅λλ€#50kimjeakwan merged 30 commits intodevelopfrom
Conversation
|
""" Walkthroughμ΄ ν 리νμ€νΈλ μ¬μ©μ λ°μ΄ν° κ΄λ¦¬λ₯Ό μν μλ‘μ΄ κΈ°λ₯μ μΆκ°ν©λλ€. μ£Όμ λ³κ²½ μ¬νμ μ¬μ©μ API, λ°μ΄ν° μμ€, 리ν¬μ§ν 리, λ·° λͺ¨λΈμ ν¬ν¨νλ μ¬μ©μ κ΄λ ¨ κ΅¬μ± μμμ μ 체 μ€νμ λμ νλ κ²μ λλ€. μ΄λ μ ν리μΌμ΄μ μ μ¬μ©μ μ 보 κ²μ λ° μ²λ¦¬λ₯Ό μν μλ‘μ΄ μν€ν μ² λ μ΄μ΄λ₯Ό ꡬνν©λλ€. Changes
Poem
π Recent review detailsConfiguration used: CodeRabbit UI π Files selected for processing (4)
π§ Files skipped from review as they are similar to previous changes (4)
β° Context from checks skipped due to timeout of 90000ms (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? πͺ§ TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 16
π Outside diff range comments (1)
app/src/main/java/module/NetworkModule.kt (1)
Line range hint
63-63: baseUrlμ μμλ‘ λΆλ¦¬νμΈμ.νλμ½λ©λ "exple Base url"μ νλ‘λμ νκ²½μμ μ¬μ©ν μ μμ΅λλ€. BuildConfigλ νκ²½ λ³μλ₯Ό ν΅ν΄ κ΄λ¦¬νλ κ²μ΄ μ’μ΅λλ€.
π§Ή Nitpick comments (10)
presentation/src/main/java/viewModel/users/UsersViewModel.kt (1)
28-71: μ€λ³΅ μ½λ 리ν©ν λ§ μ μ
getUsers()μgetMyRank()ν¨μμμ μ μ¬ν λ‘μ§μ΄ λ°λ³΅λκ³ μμ΅λλ€. μ½λμ μ¬μ¬μ©μ±κ³Ό μ μ§λ³΄μμ±μ λμ΄κΈ° μν΄ κ³΅ν΅ λ‘μ§μ λ³λμ ν¨μλ‘ μΆμΆνλ κ²μ κ³ λ €ν΄ λ³΄μΈμ.μλ₯Ό λ€μ΄, λ€μκ³Ό κ°μ΄ κ³΅ν΅ λ‘μ§μ μ²λ¦¬ν μ μμ΅λλ€:
private fun handleResult(result: Result<List<DataType>>) { when (result) { is Result.Loading -> _usersUiState.value = UsersUiState.Loading is Result.Error -> _usersUiState.value = UsersUiState.Fail is Result.Success -> { if (result.data.isEmpty()) { _usersUiState.value = UsersUiState.Empty } else { _usersUiState.value = UsersUiState.Success(result.data) } } } }κ·Έλ¦¬κ³ κ° ν¨μμμλ λ€μκ³Ό κ°μ΄ μ¬μ©ν μ μμ΅λλ€:
fun getUsers() = viewModelScope.launch { getUsersUseCase() .asResult() .collectLatest { result -> handleResult(result) } } fun getMyRank() = viewModelScope.launch { getRankUseCase() .asResult() .collectLatest { result -> handleResult(result) } }data/src/main/java/remote/api/auth/UsersAPi.kt (1)
6-6: ν΄λμ€ μ΄λ¦μ μ² μ μ€λ₯μΈν°νμ΄μ€ μ΄λ¦μ΄
UsersAPiλ‘ λμ΄ μμ΅λλ€. μΌλ°μ μΈ λ€μ΄λ° 컨벀μ μ λ°λ₯΄λ©΄UsersApiλ‘ μμ νλ κ²μ΄ μ’μ΅λλ€.λ€μκ³Ό κ°μ΄ μμ νμΈμ:
-interface UsersAPi { +interface UsersApi {presentation/src/main/java/viewModel/UIstate/UsersUiState.kt (1)
5-10: μν μ΄λ¦μ λ ꡬ체μ μΌλ‘ λ³κ²½νλ κ²μ΄ μ’κ² μ΅λλ€.νμ¬ μν μ΄λ¦λ€μ΄ λ무 μΌλ°μ μ λλ€. μ¬μ©μ κ΄λ ¨ μνμμ λͺ νν νκΈ° μν΄ λ€μκ³Ό κ°μ΄ λ³κ²½νλ κ²μ μ μν©λλ€:
sealed interface UsersUiState { - object Loading : UsersUiState - object Empty : UsersUiState - data class Success(val data: List<UsersResponseModel>) : UsersUiState - object Fail : UsersUiState + object UsersLoading : UsersUiState + object UsersEmpty : UsersUiState + data class UsersSuccess(val data: List<UsersResponseModel>) : UsersUiState + object UsersFail : UsersUiState }data/src/main/java/remote/datasource/users/UsersDataSourceImpl.kt (2)
9-12: μ½λ μ€νμΌ κ°μ μ΄ νμν©λλ€.ν΄λμ€ μ μΈλΆμ νμμ κ°μ νκ³ λ¬Έμνλ₯Ό μΆκ°νλ κ²μ΄ μ’κ² μ΅λλ€:
+/** + * UsersDataSource ꡬν체 + * μ¬μ©μ μ 보λ₯Ό μλ²λ‘λΆν° κ°μ Έμ€λ μν μ λ΄λΉν©λλ€. + */ class UsersDataSourceImpl @Inject constructor( private val usersService: UsersAPi -): UsersDataSource -{ +) : UsersDataSource {
14-16: λ©μλ λ¬Έμνκ° νμν©λλ€.getUsers λ©μλμ λν μ€λͺ μ μΆκ°νκ³ , λ°νκ°κ³Ό μμΈ μ²λ¦¬μ λν λ¬Έμνκ° νμν©λλ€:
+ /** + * λͺ¨λ μ¬μ©μ μ 보λ₯Ό κ°μ Έμ΅λλ€. + * @return μ¬μ©μ μ 보 λͺ©λ‘μ ν¬ν¨νλ Flow + * @throws IOException λ€νΈμν¬ μ€λ₯ λ°μμ + * @throws HttpException API νΈμΆ μ€ν¨μ + */ override fun getUsers(): Flow<List<UsersResponse>> = performApiRequest { usersService.getUsers() }presentation/src/main/java/Untill/Result.kt (1)
15-17: asResult νμ₯ ν¨μμ μ μ©ν μ νΈλ¦¬ν° ν¨μ μΆκ°λ₯Ό κ³ λ €ν΄λ³΄μΈμνμ¬ κ΅¬νμ κΈ°λ³Έμ μΈ κΈ°λ₯μ μ μννκ³ μμ΅λλ€λ§, μλμ κ°μ μ νΈλ¦¬ν° ν¨μ μΆκ°λ₯Ό κ³ λ €ν΄λ³΄μλ©΄ μ’μ κ² κ°μ΅λλ€:
fun <T> Result<T>.getOrNull(): T? = when (this) { is Result.Success -> data else -> null } fun <T> Result<T>.getOrThrow(): T = when (this) { is Result.Success -> data is Result.Error -> throw exception is Result.Loading -> throw IllegalStateException("Loading state has no data") }data/src/main/java/remote/dto/users/response/UsersResponse.kt (2)
5-7: μ¬μ©νμ§ μλ import λ¬Έμ μ κ±°νμΈμ.
MyRankResponseModelκ³ΌMyRankResponseλ νμ¬ μ½λμμ μ¬μ©λμ§ μμ΅λλ€.-import model.myrank.response.MyRankResponseModel -import remote.dto.myrank.response.MyRankResponse
13-19: JSON νλ μ΄λ¦μ λͺ λͺ κ·μΉμ ν΅μΌνμΈμ.JSON νλ μ΄λ¦μ΄ μΌκ΄μ± μμ΄ νΌμ©λμ΄ μμ΅λλ€:
- kebab-case:
clean-Point,to-day-Clean,penalty-Point,Point-List- camelCase:
userId,name,Mybecause,becauseλ°±μλ νκ³Ό νμνμ¬ μΌκ΄λ λͺ λͺ κ·μΉ(κ°κΈμ camelCase)μ μ¬μ©νλ κ²μ΄ μ’μ΅λλ€.
app/src/main/java/module/NetworkModule.kt (1)
13-13: API ν΄λμ€ μ΄λ¦μ μ² μλ₯Ό μμ νμΈμ.
UsersAPiμ 'APi'λ 'Api'λ‘ μμ λμ΄μΌ ν©λλ€. νλ‘μ νΈ μ 체μμ μΌκ΄λ λͺ λͺ κ·μΉμ μ μ§ν΄μΌ ν©λλ€.data/src/main/java/remote/datasource/users/UsersDataSource.kt (1)
6-10: λΆνμν λΉ μ€μ μ κ±°νμΈμ.μΈν°νμ΄μ€ μ μΈκ³Ό λ©μλ μ¬μ΄μ λΆνμν λΉ μ€μ μ κ±°νμ¬ μ½λλ₯Ό λ κΉλνκ² λ§λμΈμ.
interface UsersDataSource { - - fun getUsers(): Flow<List<UsersResponse>> }
π Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
β Files ignored due to path filters (3)
buildSrc/build/kotlin/compileKotlin/cacheable/last-build.binis excluded by!**/*.binbuildSrc/build/kotlin/compileKotlin/local-state/build-history.binis excluded by!**/*.binbuildSrc/build/libs/buildSrc.jaris excluded by!**/*.jar
π Files selected for processing (18)
.idea/other.xml(1 hunks)app/src/main/java/module/NetworkModule.kt(2 hunks)app/src/main/java/module/RemoteDataSourceModule.kt(2 hunks)app/src/main/java/module/RepositoryModule.kt(2 hunks)data/src/main/java/remote/api/auth/UsersAPi.kt(1 hunks)data/src/main/java/remote/datasource/users/UsersDataSource.kt(1 hunks)data/src/main/java/remote/datasource/users/UsersDataSourceImpl.kt(1 hunks)data/src/main/java/remote/dto/rank/response/RankResponse.kt(1 hunks)data/src/main/java/remote/dto/users/response/UsersResponse.kt(1 hunks)data/src/main/java/repoistory/UsersRepositoryImpl.kt(1 hunks)domain/src/main/java/model/demerit/response/DemeritResponseModel.kt(0 hunks)domain/src/main/java/model/users/response/UsersResponseModel.kt(1 hunks)domain/src/main/java/reopoistory/UsersRepository.kt(1 hunks)domain/src/main/java/usecase/Users/GetUsersUseCase.kt(1 hunks)presentation/build.gradle.kts(4 hunks)presentation/src/main/java/Untill/Result.kt(1 hunks)presentation/src/main/java/viewModel/UIstate/UsersUiState.kt(1 hunks)presentation/src/main/java/viewModel/users/UsersViewModel.kt(1 hunks)
π€ Files with no reviewable changes (1)
- domain/src/main/java/model/demerit/response/DemeritResponseModel.kt
β Files skipped from review due to trivial changes (1)
- data/src/main/java/remote/dto/rank/response/RankResponse.kt
π§° Additional context used
πͺ GitHub Actions: Android CI
presentation/build.gradle.kts
[error] 65-65: Unresolved reference: lifecycle. The dependency 'libs.lifecycle.viewmodel.android' cannot be resolved.
[warning] Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0
π Additional comments (5)
presentation/src/main/java/Untill/Result.kt (1)
8-13: Result μΈν°νμ΄μ€ ꡬνμ΄ μ λμμ΅λλ€sealed interfaceλ₯Ό μ¬μ©ν Result νμ ꡬνμ΄ μ μ ν©λλ€. Success, Error, Loading μνλ₯Ό λͺ ννκ² κ΅¬λΆνκ³ μμ΅λλ€.
app/src/main/java/module/RepositoryModule.kt (1)
19-23: μμ‘΄μ± μ£Όμ μ€μ μ΄ μ λμμ΅λλ€Hiltλ₯Ό μ¬μ©ν Repository λ°μΈλ©μ΄ μ μ νκ² κ΅¬νλμμ΅λλ€.
app/src/main/java/module/RemoteDataSourceModule.kt (1)
19-22: λ°μ΄ν° μμ€ μμ‘΄μ± μ£Όμ μ€μ μ΄ μ λμμ΅λλ€Hiltλ₯Ό μ¬μ©ν DataSource λ°μΈλ©μ΄ μ μ νκ² κ΅¬νλμμ΅λλ€.
app/src/main/java/module/NetworkModule.kt (1)
79-83: API μ 곡μ λ©μλκ° μ¬λ°λ₯΄κ² ꡬνλμμ΅λλ€.
UsersAPiλ₯Ό μν μμ‘΄μ± μ£Όμ μ΄ μ μ νκ² κ΅¬νλμμ΅λλ€..idea/other.xml (1)
17-27: OPPO CPH2557 κΈ°κΈ° ꡬμ±μ΄ μΆκ°λμμ΅λλ€.κΈ°κΈ° ꡬμ±μ΄ μ¬λ°λ₯΄κ² μΆκ°λμμΌλ©° λ€λ₯Έ κΈ°κΈ°λ€κ³Ό λμΌν ν¨ν΄μ λ°λ₯΄κ³ μμ΅λλ€. λ€λ§ μ€μ κΈ°κΈ°μ μΌμΉνλμ§ νμΈμ΄ νμν©λλ€.
μ€μ OPPO CPH2557 κΈ°κΈ°μ μ¬μκ³Ό μΌμΉνλμ§ νμΈνκΈ° μν΄ λ€μ μ€ν¬λ¦½νΈλ₯Ό μ€νν΄μ£ΌμΈμ:
| @@ -0,0 +1,9 @@ | |||
| package reopoistory | |||
There was a problem hiding this comment.
package λͺ
μ μ€νκ° μμ΅λλ€
νμ¬ ν¨ν€μ§ λͺ
μ΄ reopoistoryλ‘ λμ΄ μμ΅λλ€. μ΄κ²μ repositoryμ μ€νλ‘ λ³΄μ
λλ€. ν¨ν€μ§ μ΄λ¦μ μμ ν΄μΌ ν©λλ€.
λ€μκ³Ό κ°μ΄ μμ νμΈμ:
-package reopoistory
+package repositoryπ Committable suggestion
βΌοΈ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| package reopoistory | |
| package repository |
| @@ -0,0 +1,17 @@ | |||
| package Untill | |||
There was a problem hiding this comment.
ν¨ν€μ§ μ΄λ¦ μ€νλ₯Ό μμ ν΄μ£ΌμΈμ
Untill ν¨ν€μ§ μ΄λ¦μ΄ Utilμ μ€νλ‘ λ³΄μ
λλ€. μΌκ΄μ±κ³Ό κ°λ
μ±μ μν΄ μμ μ΄ νμν©λλ€.
-package Untill
+package utilπ Committable suggestion
βΌοΈ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| package Untill | |
| package util |
| @@ -0,0 +1,18 @@ | |||
| package repoistory | |||
There was a problem hiding this comment.
ν¨ν€μ§ μ΄λ¦ μ€νλ₯Ό μμ ν΄μ£ΌμΈμ
repoistory ν¨ν€μ§ μ΄λ¦μ΄ repositoryμ μ€νλ‘ λ³΄μ
λλ€.
-package repoistory
+package repositoryπ Committable suggestion
βΌοΈ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| package repoistory | |
| package repository |
| override suspend fun getUsers(): Flow<List<UsersResponseModel>> { | ||
| return usersDataSource.getUsers().map { list -> list.map { it.toModel() } } | ||
| } |
There was a problem hiding this comment.
π οΈ Refactor suggestion
μλ¬ μ²λ¦¬ λ‘μ§ μΆκ°λ₯Ό κ³ λ €ν΄λ³΄μΈμ
λ°μ΄ν° μμ€μμ λ°μν μ μλ μμΈ μν©μ λν μ²λ¦¬κ° νμν΄ λ³΄μ λλ€.
override suspend fun getUsers(): Flow<List<UsersResponseModel>> {
- return usersDataSource.getUsers().map { list -> list.map { it.toModel() } }
+ return usersDataSource.getUsers()
+ .map { list -> list.map { it.toModel() } }
+ .catch { exception ->
+ // μ μ ν λ‘κΉ
μΆκ°
+ throw exception
+ }
}π Committable suggestion
βΌοΈ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| override suspend fun getUsers(): Flow<List<UsersResponseModel>> { | |
| return usersDataSource.getUsers().map { list -> list.map { it.toModel() } } | |
| } | |
| override suspend fun getUsers(): Flow<List<UsersResponseModel>> { | |
| return usersDataSource.getUsers() | |
| .map { list -> list.map { it.toModel() } } | |
| .catch { exception -> | |
| // μ μ ν λ‘κΉ μΆκ° | |
| throw exception | |
| } | |
| } |
| import remote.datasource.users.UsersDataSource | ||
| import remote.datasource.users.UsersDataSourceImpl |
There was a problem hiding this comment.
π οΈ Refactor suggestion
μν¬νΈ κ²½λ‘λ₯Ό νμ€νν΄μ£ΌμΈμ
μν¬νΈ λ¬Έμ΄ μΌκ΄μ± μμ΄ μμ±λμ΄ μμ΅λλ€. λͺ¨λ μν¬νΈλ₯Ό νλ‘μ νΈ λ£¨νΈλΆν° μμνλλ‘ μμ ν΄μ£ΌμΈμ.
-import remote.datasource.users.UsersDataSource
-import remote.datasource.users.UsersDataSourceImpl
+import com.kim.Dormitorymanager.remote.datasource.users.UsersDataSource
+import com.kim.Dormitorymanager.remote.datasource.users.UsersDataSourceImplCommittable suggestion skipped: line range outside the PR's diff.
presentation/build.gradle.kts
Outdated
| implementation(Dependency.Compose.COMPOSE_MATERIAL3) | ||
| implementation(Dependency.Compose.COMPOSE_MATERIAL) | ||
| implementation(Dependency.Compose.COMPOSE_NAVIGATION) | ||
| implementation(libs.lifecycle.viewmodel.android) |
There was a problem hiding this comment.
μμ‘΄μ± ν΄κ²° μ€λ₯λ₯Ό μμ νμΈμ.
libs.lifecycle.viewmodel.android μμ‘΄μ±μ μ°Ύμ μ μμ΅λλ€. λ€μ μ€ νλμ λ°©λ²μΌλ‘ ν΄κ²°νμΈμ:
- λ²μ μΉ΄νλ‘κ·Έμ μμ‘΄μ±μ μΆκ°
- μ νν μμ‘΄μ± μ’νλ₯Ό μ¬μ©
λν Gradle 9.0κ³Όμ νΈνμ± λ¬Έμ λ₯Ό ν΄κ²°νκΈ° μν΄ μ΅μ λ¬Έλ²μ μ¬μ©νλ κ²μ΄ μ’μ΅λλ€.
π§° Tools
πͺ GitHub Actions: Android CI
[error] 65-65: Unresolved reference: lifecycle. The dependency 'libs.lifecycle.viewmodel.android' cannot be resolved.
[warning] Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0
There was a problem hiding this comment.
Actionable comments posted: 1
π§Ή Nitpick comments (2)
presentation/src/main/java/view/Mypage/Screen/MyPage.kt (2)
31-31: 맀κ°λ³μ λ¬Έμν κ°μ νμ
data맀κ°λ³μμ λν KDoc λ¬Έμνκ° λλ½λμμ΅λλ€. 맀κ°λ³μμ λͺ©μ κ³Ό μ¬μ©λ²μ λͺ νν μ€λͺ νλ λ¬Έμλ₯Ό μΆκ°ν΄ μ£ΌμΈμ.+/** + * @param modifier μ»΄ν¬μ λΈμ μμ μ + * @param data μ¬μ©μ μ 보 λ° λ²μ λ°μ΄ν°λ₯Ό ν¬ν¨νλ μλ΅ λͺ¨λΈ + */
126-138: ν리뷰 λ°μ΄ν° κ΄λ¦¬ κ°μ νμν리뷰 λ°μ΄ν°μ λν λͺ κ°μ§ κ°μ μ¬νμ΄ μμ΅λλ€:
- νλμ½λ©λ κ°λ€μ μμλ‘ λΆλ¦¬νμ¬ κ΄λ¦¬
- λ€μν μλλ¦¬μ€ ν μ€νΈλ₯Ό μν μ¬λ¬ ν리뷰 ν¨μ μΆκ°
- UUIDλ₯Ό κ³ μ κ°μΌλ‘ μ€μ νμ¬ μΌκ΄λ ν리뷰 μ 곡
+private object PreviewData { + val DEFAULT_USER = UsersResponseModel( + because = "λ ΈνΈλΆ", + cleanPoint = 3, + mybecause = "λ ΈνΈλΆ", + pointList = 3, + name = "μ΄μ°", + penaltyPoint = 1, + todayClean = "νμ₯μ€", + userId = UUID.fromString("550e8400-e29b-41d4-a716-446655440000") + ) +} @Composable @Preview fun PreviewMyPage() { - MyPage( - data = UsersResponseModel( - because = "λ ΈνΈλΆ", - cleanPoint = 3, - Mybecause = "λ ΈνΈλΆ", - PointList = 3, - name = "μ΄μ°", - penaltyPoint = 1, - todayClean = "νμ₯μ€", - userId = UUID.randomUUID(), - ) - ) + MyPage(data = PreviewData.DEFAULT_USER) +} + +@Composable +@Preview(name = "λμ λ²μ ") +fun PreviewMyPageHighPenalty() { + MyPage(data = PreviewData.DEFAULT_USER.copy(penaltyPoint = 5)) +}
π Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
π Files selected for processing (1)
presentation/src/main/java/view/Mypage/Screen/MyPage.kt(6 hunks)
β° Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build
π Additional comments (1)
presentation/src/main/java/view/Mypage/Screen/MyPage.kt (1)
22-22: λͺ¨λΈ λ³κ²½μ λν μν₯λ νμΈ νμ
DemeritResponseModelμμUsersResponseModelλ‘μ μ νμ΄ μ΄λ£¨μ΄μ‘μ΅λλ€. μ΄λ μ¬μ©μ κ΄λ ¨ λ°μ΄ν° ꡬ쑰μ μ€μν λ³κ²½μ μλ―Έν©λλ€.β Verification successful
λͺ¨λΈ λ³κ²½μ΄ μμ νκ² μ΄λ£¨μ΄μ‘μμ νμΈνμ΅λλ€
DemeritResponseModelμμUsersResponseModelλ‘μ μ νμ΄ μν€ν μ²μ λͺ¨λ κ³μΈ΅μμ μΌκ΄λκ² μ μ©λμμΌλ©°, UI μ»΄ν¬λνΈλ€μ λ°μ΄ν° λͺ¨λΈκ³Ό μ μ ν λΆλ¦¬λμ΄ μμ΄ μμ ν©λλ€.π Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check for any remaining references to DemeritResponseModel rg "DemeritResponseModel" --type kotlinLength of output: 39
Script:
#!/bin/bash # Search for UsersResponseModel references echo "=== UsersResponseModel References ===" rg "UsersResponseModel" --type kotlin -l echo -e "\n=== Files containing 'demerit' (case insensitive) ===" rg -i "demerit" --type kotlin -l echo -e "\n=== Model package structure ===" fd . "model" --type dLength of output: 1069
Script:
#!/bin/bash # Check content of Demerit-related files echo "=== DemeritList.kt content ===" cat presentation/src/main/java/view/Mypage/component/DemeritList.kt echo -e "\n=== MyDemeritList.kt content ===" cat presentation/src/main/java/view/Mypage/component/MyDemeritList.ktLength of output: 5720
| data.todayClean, | ||
| data.penaltyPoint, | ||
| data.cleanPoint, |
There was a problem hiding this comment.
π οΈ Refactor suggestion
νλ‘νΌν° λͺ λͺ κ·μΉ ν΅μΌ νμ
νλ‘νΌν° μ΄λ¦μμ μΌκ΄μ± μλ λͺ λͺ κ·μΉμ΄ λ°κ²¬λμμ΅λλ€:
todayClean: camelCaseMybecause: PascalCasePointList: PascalCase
Kotlin λͺ λͺ κ·μΉμ λ°λΌ λͺ¨λ νλ‘νΌν°λ camelCaseλ₯Ό μ¬μ©ν΄μΌ ν©λλ€.
- data.Mybecause,
- data.PointList,
+ data.mybecause,
+ data.pointList,Also applies to: 101-102, 115-115
| @Json(name = "to-day-Clean") val todayClean: String, | ||
| @Json(name = "name") val name: String, | ||
| @Json(name = "penalty-Point") val penaltyPoint: Int, | ||
| @Json(name = "Mybecause") val Mybecause: String, |
There was a problem hiding this comment.
kotlin κΆμ₯μ¬νμ λ°λΌμ μΉ΄λ©μΌμ΄μ€λ₯Ό μ¬μ©ν΄μ£ΌμΈμ
π :: (#50) - androidTheme λ₯Ό μΆκ°νμ΅λλ€.
4 participants
π‘ κ°μ
π μμ λ΄μ©
π λ³κ²½μ¬ν
UserAPI,
UserRepository,
UserDatasource,
UserVIewModel ,
UserResponse,
UserResponseModel,
UserRepositoryImpl,
UserDatasourceImpl
πββοΈ μ§λ¬Έμ¬ν
π΄ μ¬μ©λ°©λ²
πΈ κΈ°ν
Summary by CodeRabbit
λ¦΄λ¦¬μ¦ λ ΈνΈ
μλ‘μ΄ κΈ°λ₯
κ°μ μ¬ν
κΈ°μ μ λ³κ²½