-
Notifications
You must be signed in to change notification settings - Fork 0
๐ :: (#51) packgename์ ๋๋ฌธ์์์ ์๋ฌธ์๋ก ๋ณ๊ฒฝํ์ต๋๋ค. #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
2a29c55
:box: :: add file
kimjeakwan 36049aa
:recycle: :: packgename ์ด๋ฆ์ ๋๋ฌธ์์์ ์ ๋ถ ์๋ฌธ์๋ก ๋ณ๊ฒฝ
kimjeakwan 61dd8a7
:recycle: :: packgename ์ด๋ฆ์ ๋๋ฌธ์์์ ์ ๋ถ ์๋ฌธ์๋ก ๋ณ๊ฒฝ
kimjeakwan 8d1656b
:recycle: :: packgename ์ด๋ฆ์ ๋๋ฌธ์์์ ์ ๋ถ ์๋ฌธ์๋ก ๋ณ๊ฒฝ
kimjeakwan e12bf36
:recycle: :: packgename ์ด๋ฆ์ ๋๋ฌธ์์์ ์ ๋ถ ์๋ฌธ์๋ก ๋ณ๊ฒฝ
kimjeakwan a0adfa9
:recycle: :: packgename ์ด๋ฆ์ ๋๋ฌธ์์์ ์ ๋ถ ์๋ฌธ์๋ก ๋ณ๊ฒฝ
kimjeakwan 3cf1d4c
:recycle: :: ๊ณต๋ฐฑ์ญ์
kimjeakwan 4e6a926
:box: :: ๋น๋๋๋ฆฐํ ํ์ผ์ถ๊ฐ
kimjeakwan 9639724
:recycle: ์์กด์ฑ ๋ณ๊ฒฝ
kimjeakwan ceb5370
:recycle: ์ฐ์ง์๋ import๋ฌธ ์ ๋ฆฌ
kimjeakwan 5455009
Merge branch 'develop' into feature/51-uqdate-packgename
kimjeakwan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
buildSrc/build/classes/kotlin/main/Dependency$DataStore.class
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
buildSrc/build/classes/kotlin/main/Dependency$Retrofit.class
Binary file not shown.
Binary file not shown.
Binary file modified
BIN
+7 Bytes
(100%)
buildSrc/build/classes/kotlin/main/ProjectProperties$Versions.class
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
buildSrc/build/kotlin/compileKotlin/cacheable/caches-jvm/inputs/source-to-output.tab
Binary file not shown.
Binary file modified
BIN
-46 Bytes
(98%)
...Src/build/kotlin/compileKotlin/cacheable/caches-jvm/inputs/source-to-output.tab.values.at
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
buildSrc/build/kotlin/compileKotlin/cacheable/caches-jvm/jvm/kotlin/class-attributes.tab
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
...build/kotlin/compileKotlin/cacheable/caches-jvm/jvm/kotlin/class-attributes.tab.keystream
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
...d/kotlin/compileKotlin/cacheable/caches-jvm/jvm/kotlin/class-attributes.tab.keystream.len
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
buildSrc/build/kotlin/compileKotlin/cacheable/caches-jvm/jvm/kotlin/class-attributes.tab.len
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
buildSrc/build/kotlin/compileKotlin/cacheable/caches-jvm/jvm/kotlin/class-attributes.tab_i
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
...rc/build/kotlin/compileKotlin/cacheable/caches-jvm/jvm/kotlin/class-fq-name-to-source.tab
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
...otlin/compileKotlin/cacheable/caches-jvm/jvm/kotlin/class-fq-name-to-source.tab.keystream
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
...n/compileKotlin/cacheable/caches-jvm/jvm/kotlin/class-fq-name-to-source.tab.keystream.len
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
...uild/kotlin/compileKotlin/cacheable/caches-jvm/jvm/kotlin/class-fq-name-to-source.tab.len
Binary file not shown.
Binary file modified
BIN
+2 Bytes
(100%)
...otlin/compileKotlin/cacheable/caches-jvm/jvm/kotlin/class-fq-name-to-source.tab.values.at
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
.../build/kotlin/compileKotlin/cacheable/caches-jvm/jvm/kotlin/class-fq-name-to-source.tab_i
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
buildSrc/build/kotlin/compileKotlin/cacheable/caches-jvm/jvm/kotlin/constants.tab
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
buildSrc/build/kotlin/compileKotlin/cacheable/caches-jvm/jvm/kotlin/constants.tab.keystream
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
...rc/build/kotlin/compileKotlin/cacheable/caches-jvm/jvm/kotlin/constants.tab.keystream.len
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
buildSrc/build/kotlin/compileKotlin/cacheable/caches-jvm/jvm/kotlin/constants.tab.len
Binary file not shown.
Binary file modified
BIN
-1009 Bytes
(86%)
buildSrc/build/kotlin/compileKotlin/cacheable/caches-jvm/jvm/kotlin/constants.tab.values.at
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
buildSrc/build/kotlin/compileKotlin/cacheable/caches-jvm/jvm/kotlin/constants.tab_i
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
...rc/build/kotlin/compileKotlin/cacheable/caches-jvm/jvm/kotlin/internal-name-to-source.tab
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
...otlin/compileKotlin/cacheable/caches-jvm/jvm/kotlin/internal-name-to-source.tab.keystream
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
...n/compileKotlin/cacheable/caches-jvm/jvm/kotlin/internal-name-to-source.tab.keystream.len
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
...uild/kotlin/compileKotlin/cacheable/caches-jvm/jvm/kotlin/internal-name-to-source.tab.len
Binary file not shown.
Binary file modified
BIN
+2 Bytes
(100%)
...otlin/compileKotlin/cacheable/caches-jvm/jvm/kotlin/internal-name-to-source.tab.values.at
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
.../build/kotlin/compileKotlin/cacheable/caches-jvm/jvm/kotlin/internal-name-to-source.tab_i
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
buildSrc/build/kotlin/compileKotlin/cacheable/caches-jvm/jvm/kotlin/proto.tab
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
buildSrc/build/kotlin/compileKotlin/cacheable/caches-jvm/jvm/kotlin/proto.tab.keystream
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
buildSrc/build/kotlin/compileKotlin/cacheable/caches-jvm/jvm/kotlin/proto.tab.keystream.len
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
buildSrc/build/kotlin/compileKotlin/cacheable/caches-jvm/jvm/kotlin/proto.tab.len
Binary file not shown.
Binary file modified
BIN
-918 Bytes
(91%)
buildSrc/build/kotlin/compileKotlin/cacheable/caches-jvm/jvm/kotlin/proto.tab.values.at
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
buildSrc/build/kotlin/compileKotlin/cacheable/caches-jvm/jvm/kotlin/proto.tab_i
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
buildSrc/build/kotlin/compileKotlin/cacheable/caches-jvm/jvm/kotlin/source-to-classes.tab
Binary file not shown.
Binary file modified
BIN
-9 Bytes
(99%)
...uild/kotlin/compileKotlin/cacheable/caches-jvm/jvm/kotlin/source-to-classes.tab.values.at
Binary file not shown.
2 changes: 1 addition & 1 deletion
2
buildSrc/build/kotlin/compileKotlin/cacheable/caches-jvm/lookups/counters.tab
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,2 @@ | ||
| 6 | ||
| 5 | ||
| 0 |
Binary file modified
BIN
+0 Bytes
(100%)
buildSrc/build/kotlin/compileKotlin/cacheable/caches-jvm/lookups/file-to-id.tab
Binary file not shown.
Binary file modified
BIN
-6 Bytes
(93%)
buildSrc/build/kotlin/compileKotlin/cacheable/caches-jvm/lookups/file-to-id.tab.values.at
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
buildSrc/build/kotlin/compileKotlin/cacheable/caches-jvm/lookups/id-to-file.tab
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
buildSrc/build/kotlin/compileKotlin/cacheable/caches-jvm/lookups/id-to-file.tab.keystream
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
...dSrc/build/kotlin/compileKotlin/cacheable/caches-jvm/lookups/id-to-file.tab.keystream.len
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
buildSrc/build/kotlin/compileKotlin/cacheable/caches-jvm/lookups/id-to-file.tab.len
Binary file not shown.
Binary file modified
BIN
-30 Bytes
(88%)
buildSrc/build/kotlin/compileKotlin/cacheable/caches-jvm/lookups/id-to-file.tab.values.at
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
buildSrc/build/kotlin/compileKotlin/cacheable/caches-jvm/lookups/id-to-file.tab_i
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
buildSrc/build/kotlin/compileKotlin/cacheable/caches-jvm/lookups/lookups.tab
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
buildSrc/build/kotlin/compileKotlin/cacheable/caches-jvm/lookups/lookups.tab.keystream
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
buildSrc/build/kotlin/compileKotlin/cacheable/caches-jvm/lookups/lookups.tab.keystream.len
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
buildSrc/build/kotlin/compileKotlin/cacheable/caches-jvm/lookups/lookups.tab.len
Binary file not shown.
Binary file modified
BIN
-76 Bytes
(92%)
buildSrc/build/kotlin/compileKotlin/cacheable/caches-jvm/lookups/lookups.tab.values.at
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
buildSrc/build/kotlin/compileKotlin/cacheable/caches-jvm/lookups/lookups.tab_i
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
buildSrc/build/kotlin/compileKotlin/cacheable/last-build.bin
Binary file not shown.
Binary file modified
BIN
-61 Bytes
(75%)
buildSrc/build/kotlin/compileKotlin/local-state/build-history.bin
Binary file not shown.
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,4 @@ | ||
|
|
||
|
|
||
| plugins { | ||
| id(Dependency.Gradle.KOTLIN) | ||
| id(Dependency.Gradle.LIBRARY) | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
presentation/src/main/java/viewModel/login/uiState/LoginUiState.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
presentation/src/main/java/viewModel/login/uiState/SaveTokenUiState.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 3 additions & 2 deletions
5
...in/java/viewModel/UIstate/UsersUiState.kt โ ...a/viewModel/users/uistate/UsersUiState.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,11 @@ | ||
| package viewModel.UIstate | ||
| package viewmodel.users.uistate | ||
|
|
||
| import kotlinx.collections.immutable.ImmutableList | ||
| import model.users.response.UsersResponseModel | ||
|
|
||
| sealed interface UsersUiState { | ||
| object Loading : UsersUiState | ||
| object Empty : UsersUiState | ||
| data class Success(val data: List<UsersResponseModel>) : UsersUiState | ||
| data class Success(val data: ImmutableList<UsersResponseModel>) : UsersUiState | ||
| object Fail : UsersUiState | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <resources> | ||
| <string name="stringResource">%s: %d</string> | ||
| <string name="CleanResource">%dํ</string> | ||
| <string name="DemeritList">%s - %dํ</string> | ||
| <string name="Rank">%d๋ฑ</string> | ||
| <string name="stringResource">%1$s: %2$d</string> | ||
| <string name="CleanResource">%1$dํ</string> | ||
| <string name="DemeritList">%1$s - %2$dํ</string> | ||
| <string name="Rank">%1$d๋ฑ</string> | ||
| </resources> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
๐ ๏ธ Refactor suggestion
rememberSaveable์ํ ๋ณ์ ๋ฐ ํจ์๋ช ์ด ์ถฉ๋๋์ด ํผ๋์ ์ ๋ฐํ ์ ์์ต๋๋ค.๋์ผํ ์ด๋ฆ(
leIsClickLoginButton)์ ์ํ์ Setter ํจ์์ ํ๋ผ๋ฏธํฐ๋ก ํจ๊ป ์ฌ์ฉํ๊ณ ์์ด, ๊ฐ๋ ์ฑ๊ณผ ์ ์ง๋ณด์์ฑ์ ๋ฌธ์ ๊ฐ ์๊ธธ ์ ์์ต๋๋ค. Setter ํจ์๋ฅผ ๋ช ํํ ๊ตฌ๋ถํ ์ ์๋๋ก ์๋์ฒ๋ผ ๋ณ๊ฒฝ์ ์ ์๋๋ฆฝ๋๋ค.๐ Committable suggestion