Skip to content

πŸ› [Fix]: νšŒμ› νƒˆν‡΄ 볡ꡬ κΈ°λŠ₯ μˆ˜μ • #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
catturtle123 merged 2 commits into from
Jan 8, 2025
Merged

πŸ› [Fix]: νšŒμ› νƒˆν‡΄ 볡ꡬ κΈ°λŠ₯ μˆ˜μ • #196

catturtle123 merged 2 commits into from
Jan 8, 2025

Conversation

@catturtle123
Copy link
Collaborator

@catturtle123 catturtle123 commented Jan 8, 2025

πŸ“ PR νƒ€μž… (ν•˜λ‚˜ 이상 선택)

  • κΈ°λŠ₯ μΆ”κ°€
  • 버그 μˆ˜μ •
  • μ˜μ‘΄μ„±, ν™˜κ²½ λ³€μˆ˜, λΉŒλ“œ κ΄€λ ¨ μ½”λ“œ μ—…λ°μ΄νŠΈ
  • 기타 μ‚¬μ†Œν•œ μˆ˜μ •

❗️ κ΄€λ ¨ 이슈 링크

Close #195

πŸ“Œ κ°œμš”

  • νšŒμ› νƒˆν‡΄ 볡ꡬ κΈ°λŠ₯ μˆ˜μ •

πŸ” λ³€κ²½ 사항

  • νšŒμ› νƒˆν‡΄ 볡ꡬ swagger μˆ˜μ •
    c49dfd0

  • νšŒμ› νƒˆν‡΄ 볡ꡬ κΈ°λŠ₯ μˆ˜μ •
    c5762e4

πŸ“Έ μŠ€ν¬λ¦°μƒ·

πŸ‘€ 기타 더 이야기해볼 점

βœ… 체크 리슀트

  • PR ν…œν”Œλ¦Ώμ— λ§žμΆ”μ–΄ μž‘μ„±ν–ˆμ–΄μš”.
  • λ³€κ²½ λ‚΄μš©μ— λŒ€ν•œ ν…ŒμŠ€νŠΈλ₯Ό μ§„ν–‰ν–ˆμ–΄μš”.
  • ν”„λ‘œκ·Έλž¨μ΄ μ •μƒμ μœΌλ‘œ λ™μž‘ν•΄μš”.
  • PR에 μ μ ˆν•œ 라벨을 μ„ νƒν–ˆμ–΄μš”.
  • λΆˆν•„μš”ν•œ μ½”λ“œλŠ” μ‚­μ œν–ˆμ–΄μš”.

@catturtle123 catturtle123 linked an issue Jan 8, 2025 that may be closed by this pull request
πŸ› [Fix] νƒˆν‡΄ 볡ꡬ κΈ°λŠ₯ μˆ˜μ • #195
Closed
1 task
@catturtle123 catturtle123 requested review from 88dldl and eomgerm January 8, 2025 11:08
@catturtle123 catturtle123 self-assigned this Jan 8, 2025
@catturtle123 catturtle123 added the πŸ› bug Something isn't working label Jan 8, 2025
@catturtle123 catturtle123 changed the title πŸ› Fix: νšŒμ› νƒˆν‡΄ 볡ꡬ κΈ°λŠ₯ μˆ˜μ • πŸ› [Fix]: νšŒμ› νƒˆν‡΄ 볡ꡬ κΈ°λŠ₯ μˆ˜μ • Jan 8, 2025
eomgerm
eomgerm approved these changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@eomgerm eomgerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@catturtle123 catturtle123 merged commit d6d3259 into master Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eomgerm eomgerm eomgerm approved these changes

@88dldl 88dldl Awaiting requested review from 88dldl

Assignees

@catturtle123 catturtle123

Labels

πŸ› bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

πŸ› [Fix] νƒˆν‡΄ 볡ꡬ κΈ°λŠ₯ μˆ˜μ •

3 participants

@catturtle123 @eomgerm