Fix formatting issue

[HugoDelval]

There was an issue here when the Rule was too long (example: HEADER_FROM_DIFFERENT_DOMAINS) then 28-len(line) was negative. This caused this line to issue a runtime error. (Happy to discuss this if needed)

[arp242]

Could you please remove the changes to Report.String and make a separate pull request for that? That will make it easier to review the changes and write tests for them.

I'll take a look at the connection changes later this evening. Thanks! 👍

[HugoDelval]

Good idea. Done :)
(I've edited this PR and added a new one)

[arp242]

What do you think of this solution? This makes sure it works for any length. It's also how SpamAssassin prints long rule names.

diff --git i/spamc.go w/spamc.go
index d51ef44..0fbcec9 100644
--- i/spamc.go
+++ w/spamc.go
@@ -359,7 +359,12 @@ func (r Report) String() string {
                }

                line := fmt.Sprintf("%v%.1f %v", leadingSpace, t.Points, t.Rule)
-               line += strings.Repeat(" ", 28-len(line)) + t.Description + "\n"
+               nspaces := 27 - len(line)
+               spaces := " "
+               if nspaces > 0 {
+                       spaces += strings.Repeat(" ", nspaces)
+               }
+               line += spaces + t.Description + "\n"
                table += line
        }

diff --git i/spamc_test.go w/spamc_test.go
index d2418f2..44ed606 100644
--- i/spamc_test.go
+++ w/spamc_test.go
@@ -267,6 +267,7 @@ func TestParseReport(t *testing.T) {
                                 0.4 INVALID_DATE           Invalid Date: header (not RFC 2822)
                                -0.0 NO_RELAYS              Informational: message was not relayed via SMTP
                                -1.2 MISSING_HEADERS        Missing To: header
+                                0.1 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail are different
                        `),
                        Report{
                                Intro: normalizeSpace(`
@@ -297,6 +298,11 @@ func TestParseReport(t *testing.T) {
                                                Rule:        "MISSING_HEADERS",
                                                Description: "Missing To: header",
                                        },
+                                       {
+                                               Points:      0.1,
+                                               Rule:        "HEADER_FROM_DIFFERENT_DOMAINS",
+                                               Description: "From and EnvelopeFrom 2nd level mail are different",
+                                       },
                                },
                        },
                },

[arp242]

I fixed it with the above patch in #20. Thanks!

[HugoDelval]

Looks great ! :)