fix issue with report dealing newlines, also turned lib to go module #23
Conversation
|
Thanks! Would you mind adding a test case in |
spamc.go
Outdated
| last := len(report.Table) - indexShift | ||
| if last >= 0 { | ||
| line = strings.TrimSpace(line) | ||
| report.Table[last].Description += "\n " + line |
There was a problem hiding this comment.
I think this would be clearer with strings.Repeat(); for example (untested):
| report.Table[last].Description += "\n " + line | |
| report.Table[last].Description += "\n" + strings.Repeat(" ", 28) + strings.TrimSpace(line) |
spamc.go
Outdated
| } else { | ||
| indexShift := 1 | ||
|
|
||
| last := len(report.Table) - indexShift |
There was a problem hiding this comment.
Since indexShift is always 1 you can subtract it directly:
| last := len(report.Table) - indexShift | |
| last := len(report.Table) - 1 // Maybe comment why - 1? |
There was a problem hiding this comment.
Yes, agreed with everything. Later on, i'll do test and any code modification as suggested. Thanks 👍
|
@ripexz Could you merge this please? Or give me access to this repo? |
|
Would be better to keep the move to go.mod in a separate PR but since it's here already - please update the build script as its running on pre-gomod go versions so it's failing. Also some lint errors in there it seems, but those might also be related to go version 🤔 |
fixed isue #19
also adding support for GO module