fix(deps): update rust crate russh to 0.62.0#239
Merged
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
0.61.0→0.62.0Release Notes
warp-tech/russh (russh)
v0.62.1Compare Source
v0.62.0Compare Source
Breaking changes
#686 - make channel confirmations truly async
This changes the signature of the
Handler::channel_open_*functions to allow you to make the channel accept/reject decision outside of the main event loop. Instead of immediately returning abool, they take an additionalreply: ChannelOpenHandleargument, which you can move into another async task to confirm or reject the channel later. After the handler function returns, the event loop is immediately unblocked.This also lets you specify the protocol-level rejection reason.
Migrating your existing code:
async fn channel_open_session( &mut self, channel: Channel<Msg>, + reply: server::ChannelOpenHandle, session: &mut Session, - ) -> Result<bool, Self::Error> { + ) -> Result<(), Self::Error> { if (...) { - Ok(false) + reply.reject(ChannelOpenFailure::AdministrativelyProhibited).await; } else { - Ok(true) + reply.accept().await; } + Ok(()) }Changes
New Contributors
Full Changelog: Eugeny/russh@v0.61.2...v0.62.0
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.