fix: harden multimodal dataset loading - #381
Merged
yghstill merged 1 commit intoSep 4, 2026
Merged
Conversation
Contributor
Author
|
Hi maintainers, just a gentle ping on this PR in case it got buried. No rush — would appreciate a review when you get a chance. Thanks! |
yghstill
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Harden multimodal and omni dataset loading for calibration/test data.
This fixes
MultiModalDatasetwhenquant_algoisNone, so sparsity-only or distill-only flows no longer crash on"int4_" in None. It also wraps non-user omni messages as text content instead of dropping assistant/system turns from the conversation.Additional regression tests cover the
quant_algo=Nonepath, missing image error handling, non-list multimodal content, and preservation of assistant/system omni messages.Test Plan
python -m pre_commit run --all-files --show-diff-on-failurepython -m py_compile angelslim\data\multimodal_dataset.py angelslim\data\omni_dataset.py tests\test_multimodal_dataset.py tests\test_omni_dataset.py