Skip to content

fix(dialog): ensure handleClick is defined before invoking in useSameTarget #5672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 2, 2025
Merged

fix(dialog): ensure handleClick is defined before invoking in useSameTarget #5672

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05cafe9
fix(dialog): ensure handleClick is defined before invoking in useSame…
RSS1102 Jun 30, 2025
dcd6c78
chore: 使用可选链避免函数调用不存在
RSS1102 Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/components/dialog/hooks/useSameTarget.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ export function useSameTarget(handleClick?: (e: MouseEvent) => void) {
let MOUSEUP_TARGET = false;

const onClick = (e: MouseEvent) => {
if (MOUSEDOWN_TARGET && MOUSEUP_TARGET) {
if (MOUSEDOWN_TARGET && MOUSEUP_TARGET && handleClick) {
handleClick(e);
}
MOUSEDOWN_TARGET = false;
Expand Down