Skip to content

feat(ImageViewer): add default trigger and simplify demos #5935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Sep 25, 2025
Merged

feat(ImageViewer): add default trigger and simplify demos #5935

merged 17 commits into from
Sep 25, 2025
+303 −336

Conversation

EthanShen10086
Copy link
Contributor

@EthanShen10086 EthanShen10086 commented Aug 26, 2025 •
edited by uyarn
Loading

🤔 这个 PR 的性质是？

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

#5639

💡 需求背景和解决方案

📝 更新日志

  • 本条 PR 不需要纳入 Changelog

tdesign-vue-next

  • feat(ImageViewer): 新增默认 trigger ，默认为当前使用的图片作为默认 trigger，降低组件的使用难度，具体参考相关示例改动

@tdesign-vue-next/chat

@tdesign-vue-next/auto-import-resolver

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项。⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@uyarn uyarn changed the title Fix/issue 5639 feat(ImageViewer): add default trigger Aug 27, 2025
@liweijie0812
Copy link
Collaborator

/update-common

@tdesign-bot
Copy link
Collaborator

tdesign-bot commented Aug 27, 2025 •
edited
Loading

TDesign Component Site Preview Open

Component Preview
tdesign-vue-next 完成
@tdesign-vue-next/chat 完成

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Aug 27, 2025 •
edited
Loading

tdesign-vue-next-demo

npm i https://pkg.pr.new/Tencent/tdesign-vue-next/@tdesign-vue-next/auto-import-resolver@5935

npm i https://pkg.pr.new/Tencent/tdesign-vue-next@5935

npm i https://pkg.pr.new/Tencent/tdesign-vue-next/@tdesign-vue-next/chat@5935

commit: e8dc6f6

Wesley-0808
Wesley-0808 reviewed Aug 27, 2025
View reviewed changes
@Wesley-0808 Wesley-0808 reopened this Aug 28, 2025
@Wesley-0808
Copy link
Collaborator

/update-common

Wesley-0808
Wesley-0808 reviewed Sep 5, 2025
View reviewed changes
@Wesley-0808
Copy link
Collaborator

/update-snapshot

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 8, 2025

⏳ 正在运行快照更新。。。 CI: Open

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 8, 2025

⏳ 正在运行快照更新。。。 CI: Open

@Wesley-0808
Copy link
Collaborator

/update-common

@Wesley-0808
Copy link
Collaborator

/update-snapshot

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 9, 2025

⏳ 正在运行快照更新。。。 CI: Open

@Wesley-0808
Copy link
Collaborator

/update-snapshot

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 9, 2025

⏳ 正在运行快照更新。。。 CI: Open

@Wesley-0808
Copy link
Collaborator

⚠️ pending until Tencent/tdesign-common#2278 merged.

@EthanShen10086
Copy link
Contributor Author

⚠️ pending until Tencent/tdesign-common#2278 merged.

提交的common style有点问题吗

@Wesley-0808
Copy link
Collaborator

提交的common style有点问题吗

是的，几个小问题

EthanShen10086
EthanShen10086 commented Sep 9, 2025
View reviewed changes
@uyarn
Copy link
Collaborator

uyarn commented Sep 19, 2025

/update-common

@Wesley-0808
Copy link
Collaborator

Wesley-0808 commented Sep 19, 2025 •
edited
Loading

@EthanShen10086 demo也改一下？

@EthanShen10086
Copy link
Contributor Author

@EthanShen10086 demo也改一下？

文档我在哪里改？

@Wesley-0808
Copy link
Collaborator

@EthanShen10086 demo也改一下？

文档我在哪里改？

改example文件夹下面的demo

@uyarn uyarn changed the title feat(ImageViewer): add default trigger feat(ImageViewer): add default trigger and simplify demos Sep 25, 2025
@uyarn uyarn merged commit 4873685 into Tencent:develop Sep 25, 2025
1 check passed
@tdesign-bot tdesign-bot mentioned this pull request Sep 25, 2025
Merged
16 tasks
@Wesley-0808 Wesley-0808 mentioned this pull request Sep 28, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wesley-0808 Wesley-0808 Wesley-0808 left review comments

@uyarn uyarn uyarn approved these changes

@PengYYYYY PengYYYYY Awaiting requested review from PengYYYYY PengYYYYY is a code owner

@chaishi chaishi Awaiting requested review from chaishi chaishi is a code owner

@zhangpaopao0609 zhangpaopao0609 Awaiting requested review from zhangpaopao0609 zhangpaopao0609 is a code owner

@liweijie0812 liweijie0812 Awaiting requested review from liweijie0812 liweijie0812 is a code owner

@Cat1007 Cat1007 Awaiting requested review from Cat1007 Cat1007 is a code owner

@zydemail zydemail Awaiting requested review from zydemail zydemail is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@EthanShen10086 @liweijie0812 @tdesign-bot @Wesley-0808 @uyarn